-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not possible to import using go mod vendor
#251
Comments
Hi! Thanks for reporting this. Your solution of |
Closed
pwaller
added a commit
to pwaller/glfw
that referenced
this issue
Nov 24, 2019
This allows "go mod vendor" to copy the files out of the tree, where otherwise they would be ignored. Fixes go-gl#251.
pwaller
added a commit
to pwaller/glfw
that referenced
this issue
Nov 24, 2019
This allows "go mod vendor" to copy the files out of the tree, where otherwise they would be ignored. Fixes go-gl#251.
Can the associated pull request be merged and this issue closed out? I've stumbled across this issue too in the context of modules/vendoring. Thanks |
@rbrownrigg if you test it and leave a message on the PR saying it solves the problem for you, I'll merge it. |
Unfortunately it don't 😢, see my comment in the PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, as is now its not possible to import go-gl via the vendor directory using
go mod vendor
.The reason is that
go mod vendor
prunes all directories with.c
files that does not have a companion.go
file.This results in failed builds due to lacking
.c
sources, e.g.vendor/github.com/go-gl/glfw/v3.2/glfw/c_glfw.go:4:10: fatal error: 'glfw/src/context.c' file not found
This is expected behavior on the
go mod vendor
part (see https://github.com/golang/go/wiki/Modules#some-needed-files-may-not-be-present-in-populated-vendor-directory) but basically means that go-gl is not possible to vendor.Would it be possible to solve this by bundling a
dummy.go
file in the affected directories?The text was updated successfully, but these errors were encountered: