Fix PullRequestList.GetIssueIDs's logic #31352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
added
the
skip-changelog
lunny
approved these changes
Jun 13, 2024
GiteaBot
added
lgtm/need 1
yp05327
changed the title
delvh
approved these changes
Jun 13, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 14, 2024
* giteaofficial/main: Extract and display readme and comments for Composer packages (go-gitea#30927) Have new announcement about docs contributions (go-gitea#31364) Fix bug filtering issues which have no project (go-gitea#31337) Refactor to use UnsafeStringToBytes (go-gitea#31358) [skip ci] Updated translations via Crowdin Fix PullRequestList.GetIssueIDs's logic (go-gitea#31352) [Refactor] Unify repo search order by logic (go-gitea#30876)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a bug from #30490
prs.GetIssueIDs()will also be used in other places, e.g.InvalidateCodeCommentsso we should not add
if pr.Issue == nilin it, or ifpr.Issueis already loaded, you will not get the issueID in the results list and this is not an expected result.So this will caused a bug:
before calling
InvalidateCodeComments, allpr.Issuesinprsare loaded, soissueIDsin this function will always be[].