Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug filtering issues which have no project #31337

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix bug filtering issues which have no project #31337

merged 2 commits into from
Jun 14, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 12, 2024 •
edited
Loading

Fix #31327
This is a quick patch to fix the bug.
Some parameters are using 0, some are using -1. I think it needs a refactor to keep consistent. But that will be another PR.

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Jun 12, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 14, 2024
@lunny lunny enabled auto-merge (squash) June 14, 2024 02:02
@lunny lunny merged commit e4abaff into go-gitea:main Jun 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 14, 2024
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.22. @lunny, please send one manually. 🍵

go run ./contrib/backport 31337
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 14, 2024
@lunny lunny deleted the lunny/fix_issue_filter_project branch June 14, 2024 03:11
lunny added a commit to lunny/gitea that referenced this pull request Jun 14, 2024
@lunny
Fix bug filtering issues which have no project (go-gitea#31337)
7fb19f3 
Fix go-gitea#31327
This is a quick patch to fix the bug.
Some parameters are using 0, some are using -1. I think it needs a
refactor to keep consistent. But that will be another PR.
@lunny lunny mentioned this pull request Jun 14, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jun 14, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e5a9688 
* giteaofficial/main:
  Extract and display readme and comments for Composer packages (go-gitea#30927)
  Have new announcement about docs contributions (go-gitea#31364)
  Fix bug filtering issues which have no project (go-gitea#31337)
  Refactor to use UnsafeStringToBytes (go-gitea#31358)
  [skip ci] Updated translations via Crowdin
  Fix PullRequestList.GetIssueIDs's logic  (go-gitea#31352)
  [Refactor] Unify repo search order by logic (go-gitea#30876)
lunny added a commit that referenced this pull request Jun 17, 2024
@lunny
Fix bug filtering issues which have no project (#31337) (#31367)
a9d1e43
@kemzeb kemzeb mentioned this pull request Jun 28, 2024
Merged
silverwind pushed a commit that referenced this pull request Jul 23, 2024
@kemzeb
Properly filter issue list given no assignees filter (#31522)
c0b5a84 
Quick fix #31520. This issue is related to #31337.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 23, 2024
@kemzeb @GiteaBot
Properly filter issue list given no assignees filter (go-gitea#31522)
8e71f05 
Quick fix go-gitea#31520. This issue is related to go-gitea#31337.
@GiteaBot GiteaBot mentioned this pull request Jul 23, 2024
Merged
wolfogre pushed a commit that referenced this pull request Jul 24, 2024
@GiteaBot @kemzeb
Properly filter issue list given no assignees filter (#31522) (#31685)
6026785 
Backport #31522 by @kemzeb

Quick fix #31520. This issue is related to #31337.

Co-authored-by: Kemal Zebari <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kemzeb kemzeb kemzeb approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Issues -> Project -> No project filter doesn't work
4 participants
@lunny @GiteaBot @delvh @kemzeb