Fix new pull request link #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantkoenig
force-pushed
the
fix/pr_link
branch
from
11f2619
to
26df5ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #3133 +/- ##
==========================================
- Coverage 34.73% 34.72% -0.01%
==========================================
Files 276 276
Lines 39949 39946 -3
==========================================
- Hits 13876 13873 -3
Misses 24076 24076
Partials 1997 1997
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
|
If click on the baserepo? |
|
@lunny I'm not sure what you're asking |
|
@ethantkoenig if you click on new pull request in base repository (to create PR between it's branches) |
|
If you click on the button in the base repo, you'll create a PR from whatever branch you're currently looking at (in the base repo) to the default branch (presumably master) in the base repo. |
3 tasks
|
Tested and both cases seems to be working just as expected. LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
appleboy
approved these changes
Dec 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3131 and #3132. Now, clicking the "New request button" creates a pull request whose head is the currently-viewed branch (like Github does). The button is not shown when viewing a tag or commit.