"New pull request" button shown when viewing tag/commit

[ethantkoenig]

• Gitea version (or commit ref): master
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (https://try.gitea.io/ethantkoenig/sandbox/src/commit/ccd21f083756c783bc4725512edb9992183ff941, click on the "New pull request" button for the 404)
  • No
  • Not relevant

Description

When viewing a tag or commit, the "new pull request" button is shown. If you click on the link, you will get a 404, since the head of a PR must be a branch.

I think that ideally the button should not be shown when viewing a tag/commit.

[Albert221]

I'd like to work on that.

[lafriks]

@Albert221 I think there is already PR to fix this

[Albert221]

@lafriks could you confirm? I don't see any opened PRs addressing that

[lafriks]

@ethantkoenig wrote that in #3133 description that it fixes this issue but in code somehow I don't see this

[ethantkoenig]

Oh, I forgot to push my latest changes to #3133. Yes, #3133 will fix this issue

[lafriks]

Fixed by #3133