Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix INI parsing for value with trailing slash #26995

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Fix INI parsing for value with trailing slash #26995

merged 2 commits into from
Sep 10, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #26977 (a temp fix)

@wxiaoguang wxiaoguang added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 labels Sep 10, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Sep 10, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2023
@KN4CK3R KN4CK3R enabled auto-merge (squash) September 10, 2023 15:46
@KN4CK3R KN4CK3R merged commit e7745c9 into go-gitea:main Sep 10, 2023
@GiteaBot GiteaBot mentioned this pull request Sep 10, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 10, 2023
@wxiaoguang @GiteaBot
Fix INI parsing for value with trailing slash (go-gitea#26995)
900441a 
Fix go-gitea#26977 (a temp fix)
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Sep 10, 2023
KN4CK3R pushed a commit that referenced this pull request Sep 10, 2023
@GiteaBot @wxiaoguang
Fix INI parsing for value with trailing slash (#26995) (#27001)
da7d7e6 
Backport #26995 by @wxiaoguang

Fix #26977 (a temp fix)

Co-authored-by: wxiaoguang <[email protected]>
@wxiaoguang wxiaoguang deleted the fix-ini-load branch September 11, 2023 01:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 11, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
793a96b 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Add some more labels to labeler (go-gitea#26987)
  Fix INI parsing for value with trailing slash (go-gitea#26995)
  Correct the database.LOG_SQL default value in config cheat sheet (go-gitea#26997)
  Improve "language stats" UI (go-gitea#26968)
  [skip ci] Updated translations via Crowdin
  Update chroma to v2.9.1 (go-gitea#26990)
  Improve issue list layout (go-gitea#26983)
@delvh delvh added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Sep 13, 2023
@delvh
Copy link
Member

delvh commented Sep 13, 2023

While I generally agree, this is by definition a breaking change.
So, please follow the usual procedure of notifying users how to fix it in the description.

@delvh delvh removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Sep 17, 2023
@delvh
Copy link
Member

delvh commented Sep 17, 2023

If I understand the discussion in #27001 correctly, this PR is not breaking?

@wxiaoguang
Copy link
Contributor Author

I think it's not that "breaking" because it is a longstanding "bug". If a user wrote E:\ or E:\gitea\data\log\ in 1.19, the parser still doesn't work correctly.

But if any user ever used undocumented:

KEY = I used undocumented \
config syntax for very long value

Then this PR doesn't work with it anymore.

I think we can mention it in the changelog if we'd like to, while I guess nobody would really be affected.

nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 4, 2023
@nrdufour
chore(deps): update docker.io/gitea/gitea docker tag to v1.20.5 (#129)
f9b6839 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker.io/gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.20.4` -> `1.20.5` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs for more information.

---

### Release Notes

<details>
<summary>go-gitea/gitea (docker.io/gitea/gitea)</summary>

### [`v1.20.5`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1205---2023-10-03)

[Compare Source](go-gitea/gitea@v1.20.4...v1.20.5)

-   ENHANCEMENTS
    -   Fix z-index on markdown completion ([#&#8203;27237](go-gitea/gitea#27237)) ([#&#8203;27242](go-gitea/gitea#27242) & [#&#8203;27238](go-gitea/gitea#27238))
    -   Use secure cookie for HTTPS sites ([#&#8203;26999](go-gitea/gitea#26999)) ([#&#8203;27013](go-gitea/gitea#27013))
-   BUGFIXES
    -   Fix git 2.11 error when checking IsEmpty ([#&#8203;27393](go-gitea/gitea#27393)) ([#&#8203;27396](go-gitea/gitea#27396))
    -   Allow get release download files and lfs files with oauth2 token format ([#&#8203;26430](go-gitea/gitea#26430)) ([#&#8203;27378](go-gitea/gitea#27378))
    -   Fix orphan check for deleted branch ([#&#8203;27310](go-gitea/gitea#27310)) ([#&#8203;27320](go-gitea/gitea#27320))
    -   Quote table `release` in sql queries ([#&#8203;27205](go-gitea/gitea#27205)) ([#&#8203;27219](go-gitea/gitea#27219))
    -   Fix release URL in webhooks ([#&#8203;27182](go-gitea/gitea#27182)) ([#&#8203;27184](go-gitea/gitea#27184))
    -   Fix successful return value for `SyncAndGetUserSpecificDiff` ([#&#8203;27152](go-gitea/gitea#27152)) ([#&#8203;27156](go-gitea/gitea#27156))
    -   fix pagination for followers and following ([#&#8203;27127](go-gitea/gitea#27127)) ([#&#8203;27138](go-gitea/gitea#27138))
    -   Fix issue templates when blank isses are disabled ([#&#8203;27061](go-gitea/gitea#27061)) ([#&#8203;27082](go-gitea/gitea#27082))
    -   Fix context cache bug & enable context cache for dashabord commits' authors([#&#8203;26991](go-gitea/gitea#26991)) ([#&#8203;27017](go-gitea/gitea#27017))
    -   Fix INI parsing for value with trailing slash ([#&#8203;26995](go-gitea/gitea#26995)) ([#&#8203;27001](go-gitea/gitea#27001))
    -   Fix PushEvent NullPointerException jenkinsci/github-plugin ([#&#8203;27203](go-gitea/gitea#27203)) ([#&#8203;27249](go-gitea/gitea#27249))
    -   Fix organization field being null in POST /orgs/{orgid}/teams ([#&#8203;27150](go-gitea/gitea#27150)) ([#&#8203;27167](go-gitea/gitea#27167) & [#&#8203;27162](go-gitea/gitea#27162))
    -   Fix bug of review request number ([#&#8203;27406](go-gitea/gitea#27406)) ([#&#8203;27104](go-gitea/gitea#27104))
-   TESTING
    -   services/wiki: Close() after error handling ([#&#8203;27129](go-gitea/gitea#27129)) ([#&#8203;27137](go-gitea/gitea#27137))
-   DOCS
    -   Improve actions docs related to `pull_request` event ([#&#8203;27126](go-gitea/gitea#27126)) ([#&#8203;27145](go-gitea/gitea#27145))
-   MISC
    -   Add logs for data broken of comment review ([#&#8203;27326](go-gitea/gitea#27326)) ([#&#8203;27344](go-gitea/gitea#27344))
    -   Load reviewer before sending notification ([#&#8203;27063](go-gitea/gitea#27063)) ([#&#8203;27064](go-gitea/gitea#27064))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zLjIiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/129
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

INI value with trailing slash causes bugs
5 participants
@wxiaoguang @delvh @lunny @KN4CK3R @GiteaBot