Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow get release download files and lfs files with oauth2 token format #26430

Merged
merged 29 commits into from
Oct 1, 2023
Merged

Allow get release download files and lfs files with oauth2 token format #26430

merged 29 commits into from
Oct 1, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 10, 2023 •
edited
Loading

Fix #26165
Fix #25257

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 10, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2023
@lunny lunny mentioned this pull request Aug 10, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 10, 2023
@silverwind
Copy link
Member

backport?

@lunny lunny added the backport/v1.20 This PR should be backported to Gitea 1.20 label Aug 10, 2023
@JakobDev
Copy link
Contributor

Way better than the old PR.

Maybe we should add a Test that checks, if release assets can be downloaded from a private repo with a token, so this don't happen again.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@lunny lunny mentioned this pull request Aug 22, 2023
Open
@lunny lunny closed this Aug 24, 2023
@lunny lunny deleted the lunny/fix_download_token branch August 24, 2023 11:10
@JakobDev
Copy link
Contributor

Why was this closed?

@lunny lunny restored the lunny/fix_download_token branch August 24, 2023 12:52
@lunny lunny reopened this Aug 24, 2023
@xiaoxinpro
Copy link

Excuse me, can this PR solve the problem of using access_token to download the release asset? #26165
I see the header says "oauth2", which has nothing to do with access_token

@kirbylink
Copy link

Sorry, for posting again, but this PR is really important for me.
Are the tests now okay? Can we merge the PR?

wxiaoguang
wxiaoguang reviewed Oct 1, 2023
View reviewed changes
tests/test_utils.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 1, 2023
@6543 6543 enabled auto-merge (squash) October 1, 2023 10:10
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 1, 2023
@6543 6543 merged commit 6e87a44 into go-gitea:main Oct 1, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 1, 2023
@lunny @GiteaBot
Allow get release download files and lfs files with oauth2 token form…
77d5d78 
…at (go-gitea#26430)

Fix go-gitea#26165
Fix go-gitea#25257
This was referenced Oct 1, 2023
Merged
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 1, 2023
@lunny @GiteaBot
Allow get release download files and lfs files with oauth2 token form…
2b9ed59 
…at (go-gitea#26430)

Fix go-gitea#26165
Fix go-gitea#25257
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 1, 2023
@lunny lunny deleted the lunny/fix_download_token branch October 1, 2023 11:13
lunny added a commit that referenced this pull request Oct 1, 2023
@GiteaBot @lunny
Allow get release download files and lfs files with oauth2 token form…
4e824a7 
…at (#26430) (#27379)

Backport #26430 by @lunny

Fix #26165
Fix #25257

Co-authored-by: Lunny Xiao <[email protected]>
lunny added a commit that referenced this pull request Oct 1, 2023
@GiteaBot @lunny
Allow get release download files and lfs files with oauth2 token form…
23139aa 
…at (#26430) (#27378)

Backport #26430 by @lunny

Fix #26165
Fix #25257

Co-authored-by: Lunny Xiao <[email protected]>
@GiteaBot
Copy link
Collaborator

GiteaBot commented Oct 1, 2023

I was unable to create a backport for 1.20. @lunny, please send one manually. 🍵

go run ./contrib/backport 26430
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 1, 2023
@GiteaBot
Copy link
Collaborator

GiteaBot commented Oct 1, 2023

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 26430
...  // fix git conflicts if any
go run ./contrib/backport --continue

@lunny lunny added the backport/done All backports for this PR have been created label Oct 1, 2023
@kirbylink
Copy link

In 1.20.5 it is working again. Thanks 👍

nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 4, 2023
@nrdufour
chore(deps): update docker.io/gitea/gitea docker tag to v1.20.5 (#129)
f9b6839 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker.io/gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.20.4` -> `1.20.5` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs for more information.

---

### Release Notes

<details>
<summary>go-gitea/gitea (docker.io/gitea/gitea)</summary>

### [`v1.20.5`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#1205---2023-10-03)

[Compare Source](go-gitea/gitea@v1.20.4...v1.20.5)

-   ENHANCEMENTS
    -   Fix z-index on markdown completion ([#&#8203;27237](go-gitea/gitea#27237)) ([#&#8203;27242](go-gitea/gitea#27242) & [#&#8203;27238](go-gitea/gitea#27238))
    -   Use secure cookie for HTTPS sites ([#&#8203;26999](go-gitea/gitea#26999)) ([#&#8203;27013](go-gitea/gitea#27013))
-   BUGFIXES
    -   Fix git 2.11 error when checking IsEmpty ([#&#8203;27393](go-gitea/gitea#27393)) ([#&#8203;27396](go-gitea/gitea#27396))
    -   Allow get release download files and lfs files with oauth2 token format ([#&#8203;26430](go-gitea/gitea#26430)) ([#&#8203;27378](go-gitea/gitea#27378))
    -   Fix orphan check for deleted branch ([#&#8203;27310](go-gitea/gitea#27310)) ([#&#8203;27320](go-gitea/gitea#27320))
    -   Quote table `release` in sql queries ([#&#8203;27205](go-gitea/gitea#27205)) ([#&#8203;27219](go-gitea/gitea#27219))
    -   Fix release URL in webhooks ([#&#8203;27182](go-gitea/gitea#27182)) ([#&#8203;27184](go-gitea/gitea#27184))
    -   Fix successful return value for `SyncAndGetUserSpecificDiff` ([#&#8203;27152](go-gitea/gitea#27152)) ([#&#8203;27156](go-gitea/gitea#27156))
    -   fix pagination for followers and following ([#&#8203;27127](go-gitea/gitea#27127)) ([#&#8203;27138](go-gitea/gitea#27138))
    -   Fix issue templates when blank isses are disabled ([#&#8203;27061](go-gitea/gitea#27061)) ([#&#8203;27082](go-gitea/gitea#27082))
    -   Fix context cache bug & enable context cache for dashabord commits' authors([#&#8203;26991](go-gitea/gitea#26991)) ([#&#8203;27017](go-gitea/gitea#27017))
    -   Fix INI parsing for value with trailing slash ([#&#8203;26995](go-gitea/gitea#26995)) ([#&#8203;27001](go-gitea/gitea#27001))
    -   Fix PushEvent NullPointerException jenkinsci/github-plugin ([#&#8203;27203](go-gitea/gitea#27203)) ([#&#8203;27249](go-gitea/gitea#27249))
    -   Fix organization field being null in POST /orgs/{orgid}/teams ([#&#8203;27150](go-gitea/gitea#27150)) ([#&#8203;27167](go-gitea/gitea#27167) & [#&#8203;27162](go-gitea/gitea#27162))
    -   Fix bug of review request number ([#&#8203;27406](go-gitea/gitea#27406)) ([#&#8203;27104](go-gitea/gitea#27104))
-   TESTING
    -   services/wiki: Close() after error handling ([#&#8203;27129](go-gitea/gitea#27129)) ([#&#8203;27137](go-gitea/gitea#27137))
-   DOCS
    -   Improve actions docs related to `pull_request` event ([#&#8203;27126](go-gitea/gitea#27126)) ([#&#8203;27145](go-gitea/gitea#27145))
-   MISC
    -   Add logs for data broken of comment review ([#&#8203;27326](go-gitea/gitea#27326)) ([#&#8203;27344](go-gitea/gitea#27344))
    -   Load reviewer before sending notification ([#&#8203;27063](go-gitea/gitea#27063)) ([#&#8203;27064](go-gitea/gitea#27064))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zLjIiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/129
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
10 participants
@lunny @silverwind @JakobDev @xiaoxinpro @kerwin612 @kirbylink @GiteaBot @wxiaoguang @6543 @delvh