-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecassary calls to filepath.Join
#17608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Partialy resolvess go-gitea#17596 - Resolves `badCall` errors from go-critic `badCall: suspicious Join on 1 argument` - When only 1 argument is passed into `filepath.Join`, it won't do anything special other than `filepath.Clean(...)` will be applied over it.
Gusted
commented
Nov 10, 2021
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 10, 2021
8 tasks
lunny
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Nov 11, 2021
silverwind
approved these changes
Nov 14, 2021
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 14, 2021
lunny
approved these changes
Nov 15, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #17608 +/- ##
==========================================
- Coverage 45.48% 45.48% -0.01%
==========================================
Files 799 799
Lines 88961 88961
==========================================
- Hits 40462 40461 -1
+ Misses 42002 42001 -1
- Partials 6497 6499 +2
Continue to review full report at Codecov.
|
make L-G-T-M work. |
zeripath
pushed a commit
that referenced
this pull request
Nov 16, 2021
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
- Partialy resolvess go-gitea#17596 - Resolves `badCall` errors from go-critic `badCall: suspicious Join on 1 argument` - When only 1 argument is passed into `filepath.Join`, it won't do anything special other than `filepath.Clean(...)` will be applied over it. Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: 6543 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
badCall
errors from go-criticbadCall: suspicious Join on 1 argument
filepath.Join
, it won't do anything special other thanfilepath.Clean(...)
will be applied over it.All but 1
filepath.Join()
with 1 argument was completely removed, as they those arguments were already coming from functions or variables that already didfilepath.Join()
with multiple arguments, thus completely useless to pass it again intofilepath.Join()
.