Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue: Updating golangci-lint #17596

Closed
8 tasks done
Gusted opened this issue Nov 9, 2021 · 3 comments
Closed
8 tasks done

Tracking issue: Updating golangci-lint #17596

Gusted opened this issue Nov 9, 2021 · 3 comments
Labels
topic/code-linting type/testing

Comments

@Gusted
Copy link
Contributor

Gusted commented Nov 9, 2021 •
edited
Loading

This is a tracking-issue to update golangci-lint to a newer version - this is just to track which errors has to be fixed that comes up with the newer version of golangci-lint, v1.43.0.
The new update seems to catch more errors, which is always nice to have.
Gusted pushed a commit to Gusted/gitea that referenced this issue Nov 9, 2021
Fix nil checking on typed interface
6b22b0e 
- Partially resoles go-gitea#17596
- Resolves SA4023 errors.
- Ensure correctly that typed interface are nil.
@Gusted Gusted mentioned this issue Nov 9, 2021
Merged
Gusted pushed a commit to Gusted/gitea that referenced this issue Nov 10, 2021
Fix offBy1 errors
5b63a44 
- Partially resolves go-gitea#17596
- Resolve errors from go-critic `offBy1: Index() can return -1; maybe
you wanted to do Index()+1`.
@Gusted Gusted mentioned this issue Nov 10, 2021
Merged
Gusted pushed a commit to Gusted/gitea that referenced this issue Nov 10, 2021
Remove unnecassary calls to filepath.Join
1965009 
- Partialy resolvess go-gitea#17596
- Resolves `badCall` errors from go-critic `badCall: suspicious Join on
1 argument`
- When only 1 argument is passed into `filepath.Join`, it won't do
anything special other than `filepath.Clean(...)` will be applied over
it.
@Gusted Gusted mentioned this issue Nov 10, 2021
Merged
Gusted pushed a commit to Gusted/gitea that referenced this issue Nov 10, 2021
Remove golint as linter
1fc0054 
- Partialy resolvess go-gitea#17596
- In the newer versions of `golangci-lint`, golint is  deprecated and
replaced by the `revive` linter. Thus removing the `golint` linter is a
good idea, as we're already using the `revive` linter which covers all
the current `golint` cases.
@Gusted Gusted mentioned this issue Nov 10, 2021
Merged
Gusted pushed a commit to Gusted/gitea that referenced this issue Nov 10, 2021
Update golangci-lint in Makefile
e6b2794 
- Partially resolvess go-gitea#17596
- Download specific version(v1.43.0) by default.
- If current installed version is older than the minium version, it will
download the mininium required version.
- Update the install script to avoid deprecated error
`golangci/golangci-lint err this script is deprecated, please do not use
it anymore. check https://github.com/goreleaser/godownloader/issues/207`
@Gusted Gusted mentioned this issue Nov 10, 2021
Merged
lunny added a commit that referenced this issue Nov 11, 2021
@techknowlogick @lunny
Remove golint as linter (#17609)
a4dc0c5 
- Partialy resolvess #17596
- In the newer versions of `golangci-lint`, golint is  deprecated and
replaced by the `revive` linter. Thus removing the `golint` linter is a
good idea, as we're already using the `revive` linter which covers all
the current `golint` cases.

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 14, 2021 •
edited
Loading

(The issue was closed by PR merging automatically, reopen it. How to prevent the issue from being closed automatically?)

@wxiaoguang wxiaoguang reopened this Nov 14, 2021
@Gusted
Copy link
Contributor Author

Gusted commented Nov 14, 2021

(The issue was closed by PR merging automatically, reopen it. How to prevent the issue from being closed automatically?)

Not really, when using closing keywords on github, they will just happen. On the PRs I've on purpose add a little spelling mistake so it wont be recognized as closing keyword, this one got slipped trough.

lunny added a commit that referenced this issue Nov 15, 2021
@lunny @6543
Remove unnecassary calls to filepath.Join (#17608)
253d9e4 
- Partialy resolvess #17596
- Resolves `badCall` errors from go-critic `badCall: suspicious Join on
1 argument`
- When only 1 argument is passed into `filepath.Join`, it won't do
anything special other than `filepath.Clean(...)` will be applied over
it.

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
lunny added a commit that referenced this issue Nov 15, 2021
@lunny @wxiaoguang
Fix nil checking on typed interface (#17598)
ab13797 
* Fix nil checking on typed interface

- Partially resoles #17596
- Resolves SA4023 errors.
- Ensure correctly that typed interface are nil.

* Remove unnecessary code

`NewBleveIndexer` will never return nil, even on errors.

* Patch `NewBleveIndexer`

* Fix low-level functions

* Remove deadcode

* Fix GetSession

* Close Elastic search when err isn't nil

* Update elastic_search.go

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@Gusted Gusted mentioned this issue Nov 15, 2021
Merged
lunny added a commit that referenced this issue Nov 17, 2021
@zeripath @lunny @techknowlogick
Update golangci-lint in Makefile (#17647)
21f6c0b 
* Update golangci-lint in Makefile

- Partially resolvess #17596
- Download specific version(v1.43.0) by default.
- If current installed version is older than the minium version, it will
download the mininium required version.
- Update the install script to avoid deprecated error
`golangci/golangci-lint err this script is deprecated, please do not use
it anymore. check https://github.com/goreleaser/godownloader/issues/207`

* Simplify golangci-lint version check

* Fix version conversion

* Add version that's downloading

Co-authored-by: zeripath <[email protected]>

* Consistency

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@Gusted
Copy link
Contributor Author

Gusted commented Nov 19, 2021

Closing

@Gusted Gusted closed this as completed Nov 19, 2021
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@techknowlogick @lunny
Remove golint as linter (go-gitea#17609)
b444309 
- Partialy resolvess go-gitea#17596
- In the newer versions of `golangci-lint`, golint is  deprecated and
replaced by the `revive` linter. Thus removing the `golint` linter is a
good idea, as we're already using the `revive` linter which covers all
the current `golint` cases.

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@wxiaoguang @delvh @lunny
Fix offBy1 errors (go-gitea#17606)
f233f84 
* Fix offBy1 errors

- Partially resolves go-gitea#17596
- Resolve errors from go-critic `offBy1: Index() can return -1; maybe
you wanted to do Index()+1`.

* Match golang spec

* Remove comments

* Update migrations.go

* Apply suggestions from code review

Co-authored-by: delvh <[email protected]>

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: delvh <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@lunny @6543
Remove unnecassary calls to filepath.Join (go-gitea#17608)
527b0a1 
- Partialy resolvess go-gitea#17596
- Resolves `badCall` errors from go-critic `badCall: suspicious Join on
1 argument`
- When only 1 argument is passed into `filepath.Join`, it won't do
anything special other than `filepath.Clean(...)` will be applied over
it.

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@lunny @wxiaoguang
Fix nil checking on typed interface (go-gitea#17598)
a60605e 
* Fix nil checking on typed interface

- Partially resoles go-gitea#17596
- Resolves SA4023 errors.
- Ensure correctly that typed interface are nil.

* Remove unnecessary code

`NewBleveIndexer` will never return nil, even on errors.

* Patch `NewBleveIndexer`

* Fix low-level functions

* Remove deadcode

* Fix GetSession

* Close Elastic search when err isn't nil

* Update elastic_search.go

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@zeripath @lunny @techknowlogick
Update golangci-lint in Makefile (go-gitea#17647)
ff56c22 
* Update golangci-lint in Makefile

- Partially resolvess go-gitea#17596
- Download specific version(v1.43.0) by default.
- If current installed version is older than the minium version, it will
download the mininium required version.
- Update the install script to avoid deprecated error
`golangci/golangci-lint err this script is deprecated, please do not use
it anymore. check https://github.com/goreleaser/godownloader/issues/207`

* Simplify golangci-lint version check

* Fix version conversion

* Add version that's downloading

Co-authored-by: zeripath <[email protected]>

* Consistency

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/code-linting type/testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wxiaoguang @Gusted