Gitea 1.5.0 fails to run (segfaults) #4692

tgurr · 2018-08-13T13:52:31Z

Gitea version (or commit ref): 1.5.0
Git version: 2.18.0
Operating system: Linux
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Aug 13 15:39:19 localhost systemd[1]: Started Gitea (Git with a cup of tea).
Aug 13 15:39:19 localhost gitea[23535]: panic: runtime error: invalid memory address or nil pointer dereference
Aug 13 15:39:19 localhost gitea[23535]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x7be913]
Aug 13 15:39:19 localhost gitea[23535]: goroutine 1 [running]:
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).transformValue(0xc4202d2ea0, 0xc4202cc691, 0x28, 0xc4204cce48, 0x4ac519)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:123 +0xa3
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).String(0xc4202d2ea0, 0xc4202cb320, 0x15)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:130 +0x3d
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).MustString(0xc4202d2ea0, 0xc4202cb320, 0x15, 0x1, 0xc4202cb320)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:202 +0x2f
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/modules/setting.NewContext()
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/modules/setting/setting.go:1151 +0x4526
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/routers.GlobalInit()
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/routers/init.go:47 +0x4a
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/cmd.runWeb(0xc42036ea00, 0x0, 0x0)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/cmd/web.go:83 +0xa8
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/github.com/urfave/cli.HandleAction(0x10846a0, 0x1270720, 0xc42036ea00, 0xc420094e00, 0x0)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:471 +0xad
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/github.com/urfave/cli.Command.Run(0x1217d01, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x123677a, 0x16, 0x0, ...)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/command.go:191 +0xa0e
Aug 13 15:39:19 localhost gitea[23535]: code.gitea.io/gitea/vendor/github.com/urfave/cli.(*App).Run(0xc42001a340, 0xc4200b4040, 0x4, 0x4, 0x0, 0x0)
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:241 +0x5b8
Aug 13 15:39:19 localhost gitea[23535]: main.main()
Aug 13 15:39:19 localhost gitea[23535]:         /var/tmp/paludis/build/net-gitea-1.5.0/work/build/src/code.gitea.io/gitea/main.go:52 +0x40e
Aug 13 15:39:19 localhost systemd[1]: gitea.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Aug 13 15:39:19 localhost systemd[1]: gitea.service: Failed with result 'exit-code'.

Description

Trying to run 1.5.0 after compiling using go 1.10.3 results in the following error message. Compiling and running the previous Gitea 1.4.3 with the same options works fine. I ran into this when trying to upgrade an instance with 1.4.3 to 1.5.0, but it's also reproducible on another host with no previous Gitea installation/configuration/data present.

The text was updated successfully, but these errors were encountered:

lafriks · 2018-08-13T18:48:04Z

Can you provide app.ini you are using as it seems to be problem in it.

rbong · 2018-08-14T05:13:02Z

I am getting the same error with 1.5.0. If I don't comment out either of the last two lines from app.ini, which I pulled from app.ini.example.

[U2F]
APP_ID = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/
TRUSTED_FACETS = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/

tgurr · 2018-08-14T09:53:13Z

Commenting out the [U2F] section does the trick or me as well, thanks @rbong.

eripa · 2018-08-19T00:54:10Z

Same for me. Segfaulting unless I remove the U2F section. U2F still works with it removed though.. so maybe it's no longer needed?

lafriks · 2018-08-19T11:50:54Z

If removed it gitea uses defaults as given in sample app.ini file

eripa · 2018-08-19T15:21:55Z

Ok. This is the one I had:

[U2F]
APP_ID = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s
TRUSTED_FACETS = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s

I grabbed the U2F section from here: https://github.com/go-gitea/gitea/blob/master/custom/conf/app.ini.sample#L630

(the only difference was that it had trailing / on each setting)

and added that instead of nothing and it got back into segfaulting. There seems to be a difference between having this configured at all and just leaving it out.

lafriks · 2018-08-19T19:02:28Z

I think that / at the end is critical

eripa · 2018-08-19T19:11:12Z

I tried with the /, same issue.

…

On Aug 19, 2018, at 12:02, Lauris BH ***@***.***> wrote: I think that / at the end is critical — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

rain0r · 2018-10-11T07:17:55Z

Edit: Downgrading to 1.4.3 fixed the issue.

I'm experiencing the same error since upgrading to gitea-1.5.2.

Gitea version (or commit ref): 1.5.2
Git version: 2.19.1
Operating system: Gentoo Linux
Database: PostgreSQL 10.5

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x7f3654]

goroutine 1 [running]:
code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).transformValue(0xc0002afc20, 0xc000041861, 0x28, 0xc0004eee70, 0x4af6f9)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:123 +0xa4
code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).String(0xc0002afc20, 0xc0002ad320, 0x14)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:130 +0x3d
code.gitea.io/gitea/vendor/gopkg.in/ini%2ev1.(*Key).MustString(0xc0002afc20, 0xc0002ad320, 0x14, 0x1, 0xc0002ad320)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/gopkg.in/ini.v1/key.go:202 +0x2f
code.gitea.io/gitea/modules/setting.NewContext()
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/modules/setting/setting.go:1151 +0x45f4
code.gitea.io/gitea/routers.GlobalInit()
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/routers/init.go:47 +0x4a
code.gitea.io/gitea/cmd.runWeb(0xc00032e8c0, 0x0, 0x0)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/cmd/web.go:83 +0xaa
code.gitea.io/gitea/vendor/github.com/urfave/cli.HandleAction(0x12e1b80, 0x14dc4f0, 0xc00032e8c0, 0xc0000a9800, 0x0)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:471 +0xad
code.gitea.io/gitea/vendor/github.com/urfave/cli.Command.Run(0x146aae8, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1490463, 0x16, 0x0, ...)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/command.go:191 +0x96d
code.gitea.io/gitea/vendor/github.com/urfave/cli.(*App).Run(0xc0002844e0, 0xc0000aa040, 0x4, 0x4, 0x0, 0x0)
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:241 +0x5a2
main.main()
        /var/tmp/portage/www-apps/gitea-1.5.2/work/gitea-1.5.2/src/code.gitea.io/gitea/main.go:52 +0x3a7

lunny · 2018-10-11T13:30:12Z

It seems it's a upstream library gopkg.in/ini.v1's bug.

stefangweichinger · 2018-10-17T15:54:11Z

I also see gitea-1.5.2 fail with the U2F-section in app.ini ... and initially I added that section because adding my U2F-key (yubikey) does not work. The button "Add Security Key" does nothing here.

The URL /user/settings/security/u2f/request_register fails ... according to the 404 mentioned in my dev-tools (chrome).

ArchangeGabriel · 2018-11-24T12:10:38Z

Still present with 1.6.0.

mckaygerhard · 2018-12-11T23:22:49Z

still present at 1.5.3 and 1.6.0, still present at master!, similar as #5526 but not same, in that issue i talk about more pointed debug messages at errors

mckaygerhard · 2018-12-23T13:14:32Z

today still at 1.6.2 U2F Block In app.ini Causes A Segfault

alyandon · 2019-01-10T19:19:17Z

Looks like the problem is that PROTOCOL, DOMAIN and HTTP_PORT keys are not declared in the U2F section of the example file so the ini parser (see line 120 of transformValue() in key.go) falls back to looking for those keys in the DEFAULT section, ignores the returned error and blindly continues with the assumption that they must have been found instead of actually verifying that they were found.

I'm not sure what the expected behavior of the ini parser is but it should be easy enough to define those keys in the sample ini file in the default or U2F sections to avoid the panic on startup.

mckaygerhard · 2019-01-10T19:46:29Z

well by defining those keys or remove the sectin solves the situation, but:
yeah, now 1.7.X development and bug still present .. seems 1.6.X are default stable and the bugs its the real stable and here definitivelly

jonasfranz · 2019-01-16T23:24:48Z

A solution might be to remove the U2F section from the example config since this section is only required by a small minority of people using Gitea on multiple domains. The documentation will stay in the config cheat sheet.

alyandon · 2019-01-17T18:10:46Z

Someone should put together a minimal test case and report the issue upstream. I took a peek at their repository and they seem to be willing to fix issues but no one appears to have reported this particular panic.

The example config needs to change regardless because the most sane thing for upstream to do would be to return an error instead of panicking which would still stop gitea from starting up. At least, I wouldn't want gitea to start up if the config it is using has errors.

remove U2F section from config file due to a bug in the config parser[1]. [1] go-gitea/gitea#4692

lafriks added the type/bug label Aug 13, 2018

lafriks added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Oct 14, 2018

lafriks mentioned this issue Nov 24, 2018

U2F Block In app.ini Causes A Segfault #5394

Closed

4 tasks

lafriks mentioned this issue Nov 26, 2018

Gitea 1.6.0 Crash #5406

Closed

7 tasks

Gottox added a commit to void-linux/void-packages that referenced this issue Feb 2, 2019

gitea: update to 1.7.1.

a3c252f

remove U2F section from config file due to a bug in the config parser[1]. [1] go-gitea/gitea#4692

jolheiser mentioned this issue Feb 6, 2019

Change U2F app.ini.sample #5982

Closed

jolheiser mentioned this issue Feb 7, 2019

Update U2F Section of app.ini.sample #5994

Merged

techknowlogick closed this as completed in #5994 Feb 7, 2019

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gitea 1.5.0 fails to run (segfaults) #4692

Gitea 1.5.0 fails to run (segfaults) #4692

tgurr commented Aug 13, 2018 •

edited

Loading

lafriks commented Aug 13, 2018

rbong commented Aug 14, 2018 •

edited

Loading

tgurr commented Aug 14, 2018

eripa commented Aug 19, 2018

lafriks commented Aug 19, 2018

eripa commented Aug 19, 2018

lafriks commented Aug 19, 2018

eripa commented Aug 19, 2018 via email

rain0r commented Oct 11, 2018 •

edited

Loading

lunny commented Oct 11, 2018

stefangweichinger commented Oct 17, 2018

ArchangeGabriel commented Nov 24, 2018

mckaygerhard commented Dec 11, 2018

mckaygerhard commented Dec 23, 2018

alyandon commented Jan 10, 2019 •

edited

Loading

mckaygerhard commented Jan 10, 2019

jonasfranz commented Jan 16, 2019

alyandon commented Jan 17, 2019

Gitea 1.5.0 fails to run (segfaults) #4692

Gitea 1.5.0 fails to run (segfaults) #4692

Comments

tgurr commented Aug 13, 2018 • edited Loading

Description

lafriks commented Aug 13, 2018

rbong commented Aug 14, 2018 • edited Loading

tgurr commented Aug 14, 2018

eripa commented Aug 19, 2018

lafriks commented Aug 19, 2018

eripa commented Aug 19, 2018

lafriks commented Aug 19, 2018

eripa commented Aug 19, 2018 via email

rain0r commented Oct 11, 2018 • edited Loading

lunny commented Oct 11, 2018

stefangweichinger commented Oct 17, 2018

ArchangeGabriel commented Nov 24, 2018

mckaygerhard commented Dec 11, 2018

mckaygerhard commented Dec 23, 2018

alyandon commented Jan 10, 2019 • edited Loading

mckaygerhard commented Jan 10, 2019

jonasfranz commented Jan 16, 2019

alyandon commented Jan 17, 2019

tgurr commented Aug 13, 2018 •

edited

Loading

rbong commented Aug 14, 2018 •

edited

Loading

rain0r commented Oct 11, 2018 •

edited

Loading

alyandon commented Jan 10, 2019 •

edited

Loading