Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change U2F app.ini.sample #5982

Closed
jolheiser opened this issue Feb 6, 2019 · 1 comment · Fixed by #5994
Closed

Change U2F app.ini.sample #5982

jolheiser opened this issue Feb 6, 2019 · 1 comment · Fixed by #5994
Labels
type/bug type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@jolheiser
Copy link
Member

jolheiser commented Feb 6, 2019

Creating this issue to tie in any relevant other issues caused by this.
This is the cause of #4260 #4692 #5394 #5406 #5526 (maybe others as well, linking them here for a quick reference to close any as needed with PR, and to link back to this issue)

These lines in the app.ini.sample are referencing a key from a different section (which is invalid), and so when users copy the app.ini.sample over their own, the default values are causing Gitea to crash on startup.

I'd be happy to put in a PR to fix it, however I'd like opinions on the "best" way to do it.

  1. We could move those three values out of the [server] section and into the default section so everything has access to them.
  2. We could add those three values to the [U2F] section (I don't particularly like this implementation, as it means more redundancy)
  3. We could change the sample values to some other generic format and/or comment them out, implying users will need to change them to get them working. i.e. APP_ID = http://localhost:3000/
@techknowlogick
Copy link
Member

techknowlogick commented Feb 6, 2019

I like option 3 (commenting out existing values, and adding a note that users need to change them to get them working.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 7, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/bug type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants