Attachments In Review Comment Break With Edit #24195
Assignees
Labels
Comments
|
Until proper editing of attachments on reviews is implemented, would adding |
|
Good catch, the "attachment removal" code was already quite buggy before (this bug is not the first time appearing....) I guess we need to rewrite it. I am working on it. |
|
I guess this PR could fix the bug: Fix issue attachment handling #24202 |
silverwind
added a commit
that referenced
this issue
Apr 20, 2023
Close #24195 Some of the changes are taken from my another fix f07b0de in #20147 (although that PR was discarded ....) The bug is: 1. The old code doesn't handle `removedfile` event correctly 2. The old code doesn't provide attachments for type=CommentTypeReview This PR doesn't intend to refactor the "upload" code to a perfect state (to avoid making the review difficult), so some legacy styles are kept. --------- Co-authored-by: silverwind <[email protected]> Co-authored-by: Giteabot <[email protected]>
silverwind
added a commit
that referenced
this issue
Apr 20, 2023
Backport #24202 Close #24195 Fix the bug: 1. The old code doesn't handle `removedfile` event correctly 2. The old code doesn't provide attachments for type=CommentTypeReview --------- Co-authored-by: silverwind <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
To Reproduce
It seems as if all of the attachments are deleted when the review is edited.
Related to: #23290 and #24196
Gitea Version
1.18 and 1.20 (try.gitea)
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Paste some images (note: attachments aren't indicated)
Edit the review comment
All attachments are broken
Git Version
No response
Operating System
No response
How are you running Gitea?
https://try.gitea.io/kdumontnu/test/pulls/2
Database
None
The text was updated successfully, but these errors were encountered: