Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commits Showing Author By Full Name Not Username #20446

Closed
Deadmano opened this issue Jul 21, 2022 · 0 comments · Fixed by #30096
Closed

Commits Showing Author By Full Name Not Username #20446

Deadmano opened this issue Jul 21, 2022 · 0 comments · Fixed by #30096
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@Deadmano
Copy link

Description

It seems that #6710 added supported to toggle showing full names, but commit messages still show the full name of the Gitea user. This is confirmed by changing the full name under account to anything else, which the commit author then takes on.

The commit graph has the same issue, although I do believe it (and other portions) are linked to the same thing.

The user heatmap and other areas such as pull requests behave as expected, respecting the DEFAULT_SHOW_FULL_NAME config setting when set to false and only showing the username.

Expected behaviour: The author section under commits shows the username of the user, and not their full name.

Having an option/toggle for this would be extremely helpful. To ensure consistent username display site-wide with regards to repos.

Screenshots

Repo_Issue

Gitea Version

1.17.0

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows 10

Browser Version

Firefox 102
@Deadmano Deadmano added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 21, 2022
@yp05327 yp05327 mentioned this issue Mar 26, 2024
Merged
techknowlogick pushed a commit that referenced this issue Mar 28, 2024
@yp05327
Fix DEFAULT_SHOW_FULL_NAME=false has no effect in commit list and c…
6103623 
…ommit graph page (#30096)

Fix #20446

This PR will fix the username in:
repo home page

![image](https://github.com/go-gitea/gitea/assets/18380374/347c0f70-ea42-432d-aae3-bf87a7e07ae1)
repo commit list page

![image](https://github.com/go-gitea/gitea/assets/18380374/b3b1f5d5-c371-4222-ac2e-64b8994c7551)
repo commit graph page

![image](https://github.com/go-gitea/gitea/assets/18380374/01b7117c-3aea-4d7d-8bd1-35e5ea942821)
pr commit page

![image](https://github.com/go-gitea/gitea/assets/18380374/4d180c30-2150-4348-8eeb-0b4b2559ec19)

Will not fix:
wiki revisions page:

![image](https://github.com/go-gitea/gitea/assets/18380374/b49df6bf-d751-4374-b7ea-1ac85e2739e3)
ps: the author name is `FullName` by default
@na-Itms na-Itms mentioned this issue Jun 25, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DEFAULT_SHOW_FULL_NAME=false has no effect in commit list and commit graph page yp05327/gitea
1 participant
@Deadmano