-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show full name if DEFAULT_SHOW_FULL_NAME setting enabled #6710
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6710 +/- ##
=========================================
Coverage ? 41.32%
=========================================
Files ? 432
Lines ? 59552
Branches ? 0
=========================================
Hits ? 24611
Misses ? 31703
Partials ? 3238
Continue to review full report at Codecov.
|
Please also add the new option to app.ini.sample and possibly the config cheat sheets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking per @silverwind's comment re: docs.
done |
Thanks. One more thing I missed is the |
@silverwind zh-cn is simplified Chinese, but like you said translations for this can wait for a different PR. |
I would prefer if it would be named as |
|
This is replacing something relatively limited like usernames -- which can only be letters, numbers, _, and . -- with user controlled input that currently has no real limitations other than length. Unfortunately, I don't think Gitea can safely handle this type of change as-is without some more in depth testing. I checked out this PR and was able to find a security issue within a few minutes: Create an issue with a user. Change the users full name to Then visit http://example.com/user/repo/issues It will execute the code above. This is true for any of the At minimum there should need to be some type of sanitizing of the full name and double checking of every location that would use it to make sure it isn't easy to break out of the expected HTML as seen above. |
Adds a new key DEFAULT_SHOW_FULL_NAME (default false) to the [ui] section. If enabled the full name will be shown (unless it's empty, then the default username will be used)
|
Fixes #3697 and #3509
Adds a new key DEFAULT_SHOW_FULL_NAME (default false) to the [ui] section.
If enabled the full name will be shown (unless it's empty, then
the default username will be used)