For multiline commands, only use the first line and "..." as the label #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a multiline command is used with "run" action, it’s sometimes
difficult to figure out what’s going on, as it’s printed in its entirety
for the each line of its own output. For example:
actions:
- action: run
chroot: false
command: |
echo test1
echo test2
echo test3
Prints this:
2022/04/15 10:52:46 echo test1
echo test2
echo test3
| test1
2022/04/15 10:52:46 echo test1
echo test2
echo test3
| test2
2022/04/15 10:52:46 echo test1
echo test2
echo test3
For clarity, it’s better to only use the first line:
2022/04/15 11:03:10 echo test1... | test1
2022/04/15 11:03:10 echo test1... | test2
2022/04/15 11:03:10 echo test1... | test3
Signed-off-by: Andrej Shadura <[email protected]>
obbardc
requested changes
Apr 15, 2022
obbardc
reviewed
Apr 15, 2022
Very long commands clutter the logs too, so shortening them up should
also be helpful:
- action: run
chroot: false
command: |
echo test1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
echo test2
echo test3
It will print this:
2022/04/15 15:24:49 echo test1 2 3 4 5 6 7 8 9 10 11 12 13 1... | test1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
2022/04/15 15:24:49 echo test1 2 3 4 5 6 7 8 9 10 11 12 13 1... | test2
2022/04/15 15:24:49 echo test1 2 3 4 5 6 7 8 9 10 11 12 13 1... | test3
On the other hand, a single-line command written as a multiline string
is still a single-line command:
- action: run
chroot: false
command: |
echo test1
Should print:
2022/04/15 15:29:27 echo test1 | test1
Signed-off-by: Andrej Shadura <[email protected]>
andrewshadura
force-pushed
the
multiline-commands
branch
from
80b3020 to
9bacb36
Compare
obbardc
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a multiline command is used with "run" action, it’s sometimes
difficult to figure out what’s going on, as it’s printed in its entirety
for the each line of its own output. For example:
Prints this:
For clarity, it’s better to only use the first line: