Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic efi image #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mimi89999
Copy link

No description provided.

@mimi89999 mimi89999 mentioned this pull request Mar 1, 2021
Copy link

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me I can simplify mine #20

- action: run
description: Add user
chroot: true
command: sh -c "adduser --gecos {{ $username }} --disabled-password --shell /bin/bash {{ $username }};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debos already wraps the command in sh -c, there’s no need to do so once again.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do this:

    command: |
      adduser --gecos {{ $username }} --disabled-password --shell /bin/bash {{ $username }}
      adduser {{ $username }} sudo
      echo "{{ $username }}:{{ $password }}" | chpasswd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downside of using | is that until go-debos/debos#321 is merged, it’s going to look a bit untidy in the logs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or add label: foo to the recipe? :-)

- action: run
description: Install GRUB
chroot: true
command: sh -c "update-grub;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants