-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic efi image #21
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me I can simplify mine #20
- action: run | ||
description: Add user | ||
chroot: true | ||
command: sh -c "adduser --gecos {{ $username }} --disabled-password --shell /bin/bash {{ $username }}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debos already wraps the command in sh -c
, there’s no need to do so once again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do this:
command: |
adduser --gecos {{ $username }} --disabled-password --shell /bin/bash {{ $username }}
adduser {{ $username }} sudo
echo "{{ $username }}:{{ $password }}" | chpasswd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downside of using |
is that until go-debos/debos#321 is merged, it’s going to look a bit untidy in the logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or add label: foo
to the recipe? :-)
- action: run | ||
description: Install GRUB | ||
chroot: true | ||
command: sh -c "update-grub; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
No description provided.