Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal text isn't shown on lost focus of multiple tabs and hidden scroll bar #372

Closed
Syndamia opened this issue Jan 21, 2021 · 18 comments
Closed
Labels
bug Something isn't working

Comments

@Syndamia
Copy link

Describe the bug

When having multiple tabs open, the scrollbar is hidden on the currently opened tab and the terminal isn't in focus, the text in it isn't rendered.

To Reproduce

Steps to reproduce the behavior:

  1. Open Terminator
  2. Open another tab
  3. Right-click and deselect "Show scrollbar"
  4. Un-focus it, meaning click anywhere that isn't on the terminal

Expected behavior

When you click out of Terminator (when it isn't in focus), in all cases, it should still show the text in it.

Screenshots

Peek 2021-01-21 15-36
Here I show that it works as expected in all cases, except when the scroll bar is hidden and a tab is opened

Desktop (please complete the following information):

  • OS or Linux Distribution: Fedora 33 (Cinnamon)
  • Terminator Version: 2.1.0

Additional context

My config file (although it shouldn't have anything that could cause this issue)
[global_config]
  focus = system
  handle_size = 1
  sticky = True
  suppress_multiple_term_dialog = True
[keybindings]
[profiles]
  [[default]]
    audible_bell = True
    background_color = "#282828"
    background_darkness = 0.95
    cursor_color = "#aaaaaa"
    font = MesloLGS NF 12
    foreground_color = "#ebdbb2"
    show_titlebar = False
    scrollback_infinite = True
    palette = "#282828:#cc241d:#98971a:#d79921:#458588:#b16286:#689d6a:#a89984:#928374:#fb4934:#b8bb26:#fabd2f:#83a598:#d3869b:#8ec07c:#ebdbb2"
    use_system_font = False
    background_image = /home/kamen/Desktop/2020-12-03_16-49.png
[layouts]
  [[default]]
    [[[window0]]]
      type = Window
      parent = ""
    [[[child1]]]
      type = Terminal
      parent = window0
      profile = default
[plugins]
@mattrose
Copy link
Member

Try removing background_darkness and background_image from your config file. If that doesn't work, try rebuilding your default profile. I have a feeling that something was going on with the dim on focus out stuff. In your case it seems to be painting over the entire window.

@mattrose mattrose added the question Further information is requested label Jan 21, 2021
@Syndamia
Copy link
Author

Try removing background_darkness and background_image from your config file.

Didn't work

try rebuilding your default profile

Yeah, the default profile, that comes with it works fine, but that's because it has the scrollbar and title-bar (I just found out that it also affects it) shown.

Even with stock settings, if you have multiple tabs, with hidden scroll bar and top bar, and you click off, the text disappears.

@mattrose mattrose added bug Something isn't working and removed question Further information is requested labels Jan 22, 2021
@mattrose
Copy link
Member

You're right. That is really weird. I'm actually kinda stumped as to why it happens. It only seems to be in that one configuration, which doesn't really make sense. I'm gonna have to spend some time with this one.

@tstew25
Copy link

tstew25 commented Jan 23, 2021

Not sure if this issue is related, but I have noticed that having multiple panes open, the text/window doesn't update unless I click the terminator window. It will typically happen after a few commands are run and then switching to a different pane. For instance, if I have the window split vertically (two panes), I'll type some commands into the left one, switch to the right one and start typing, but the text doesn't appear. I can still run the commands but nothing will show up until I click into the window.

It doesn't seem to have this issue when I do not have the window split, i.e., just one standard window pane. I've only noticed this issue pop up within the last week or two and haven't really seen anything mentioned about it elsewhere.

Details (let me know if you'd need more info):
OS: Kali 2020.4
Terminator: 2.1.0
Shell: zsh

@mattrose
Copy link
Member

Hmm, It might no be drawing the screen right away. I think I finally figured out the cause of what was going on, but I'm just now trying to figure out how to fix it. I think the dimming on focus out is a little too eager in what it paints over when there is no scrollbar or toolbar to box it in. I still have to figure out how to give it the correct dimensions.

@hardaker
Copy link

Good news: I'm not insane.
Bad news: I see this behavior too.

For me, it's solely based on the visibility of the title bar (which I've always thought was a waste of space and turned it off (personal preference of course)). The scrollbar toggling didn't help for me; only the title bar setting in the profile fixed it. And thanks very much for this hint on what to change, because I was about to switch terminals.

@mattrose
Copy link
Member

Ugh. All right, I'll revert the code that does this and reopen #74. It's a cosmetic change anyways, and it doesn't seem to work, so... I'll push something out as soon as I can.

@mattrose
Copy link
Member

Also, @hardaker I noticed that the bug is triggered depending on where you have the scrollbar. If you have the scrollbar on the right, it stops it from happening. If you have the scrollbar on the left, it doesn't stop if from happening.

@mattrose
Copy link
Member

I've reverted the work I did for #74, which fixes this issue. Please test this out by checking out master and running. I think it's too soon to work up another release, but if anyone else comes across this they can grab the latest code.

@pipatron
Copy link

Thank you! The issue has annoyed me for months, but I can confirm that the commit solved the problem for me on Debian Testing/Gnome 3.38.3/Wayland

@edgan
Copy link

edgan commented Mar 28, 2021

I feel like a new release, even for if just for this one issue, is warranted. I very nearly stopped using terminator, because of this bug. The only thing that stopped me is I couldn't find a good enough alternative. I started using terminator again after running into like bugs with tilix.

I did make my own Fedora 33 rpm with the necessary patch, but I bet there are 10 more people for everyone that has compiled it themselves.

@mattrose What is actually involved in making a new release? Is there a need for some automation? If so, I would be willing to help.

@mattrose
Copy link
Member

I think you're right. It's about time for a new release anyways, regardless of this bug. I'll work on putting one out and getting it into F33 this week.

@jmechnich
Copy link

jmechnich commented Mar 28, 2021

It would be great if this could make it into Debian Bullseye too if it is not too late.

@mattrose
Copy link
Member

mattrose commented Apr 2, 2021

2.1.1 is out now. I can add it to Fedora, but I can't add things to Debian. @lazyfrosch can, though. 😃

@habibendris10
Copy link

I have been struggling for some time but found a solution.
The only thing to do is to go to the General tab and set Unfocused terminal font brightness to 100%.
This will set the brightness of a terminal when it is not focused.

@anurag-mehra
Copy link

I am also struggling something simillar just watch this video and you will understand text just disappers even when i am using the terminal

llo_20220315_153710.mp4

@Syndamia
Copy link
Author

@anurag-mehra your issue seems to be completely different from mine, it might be a good idea to open a separate issue

@anurag-mehra
Copy link

anurag-mehra commented Mar 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants