Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing focus on a tabbed window will grey out the window #393

Closed
grazzolini opened this issue Feb 23, 2021 · 7 comments
Closed

Losing focus on a tabbed window will grey out the window #393

grazzolini opened this issue Feb 23, 2021 · 7 comments

Comments

@grazzolini
Copy link

Describe the bug
When losing focus on a tabbed terminator window, the terminator window will be grayed out. This doesn't happen on a non-tabbed window

To Reproduce
Steps to reproduce the behavior:
Open terminator, create a tab, leave the windows focus

Expected behavior
The dimming should work on both regular windows and tabbed ones

Screenshots
https://user-images.githubusercontent.com/4093184/108853832-f0916680-75c5-11eb-9d4e-92b20d2bcc74.mp4
terminator-issue

Desktop (please complete the following information):

  • Arch Linux
  • terminator 2.1.0-1

Additional context
No compositor is running, this is plain i3 on Xorg.

@mattrose
Copy link
Member

fixed in #372

@grazzolini
Copy link
Author

I'm applying the patch to the Arch package for now.

@mattrose
Copy link
Member

Thank you! I'll probably do the same for Fedora.

@grazzolini
Copy link
Author

Do you have it handy? I'm trying to create it using format-patch, but no luck yet.

@mattrose
Copy link
Member

it was an ugly patch to try and revert. It was all in terminatorlib/terminal.py so if you just do a diff of the 2.1.0 version of that file and the current master, it should just contain that change. I'll double check

@mattrose
Copy link
Member

Nope. The attached patch should do the trick, I generated it by: git diff 4a91585d3bd2cf2e0c2eb29d55cf7204ee4c581b..01bb33eebc44d8967550236db9883ba798f38440 terminatorlib/terminal.py

terminator-patch.txt

@mattrose
Copy link
Member

apparently I've been more productive than I thought 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants