-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add p/moul/collection #3321
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
1fb34a6
to
630e8f3
Compare
Signed-off-by: moul <[email protected]>
630e8f3
to
887c1f0
Compare
Signed-off-by: moul <[email protected]>
fd8645c
to
55ce510
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some some concerning points. other things are LGTM
newKey, ok := safeGenerateKey(idx.fn, obj) | ||
if !ok { | ||
// Rollback: restore old object | ||
c.indexes[IDIndex].tree.Set(idStr, oldObj) | ||
return 0 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When rollback occurs due to safeGenerateKey
call failures or UniqueIndex
conflicts, only the _id
index of oldObj
is currently being restored.
I didn't found a mechanism to restore previously removed entries in other indices. This can lead to inconsistency between the _id
index and other indices, may potentially compromising data integrity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about fa46373?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 👍
idx.tree.Remove(idStr) | ||
continue | ||
} | ||
key := idx.fn(obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Set
function, when inserting data with the CaseInsensitiveIndex
option enabled, keys are stored after being converted to lowercase.
if idx.options&CaseInsensitiveIndex != 0 {
key = strings.ToLower(key)
}
However, it seems that the same processing is missing when removing these keys in the Delete
or Update
functions.
In this line, the code attempts to directly delete the key obtained from idx.fn(obj)
without any coversion process. I think this can lead to a unexpected behaviour which delection or updates don't work properly because the key doesn't match the actual lowercase key stored in the index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Question for reviewers: API design preference for Get/GetAll Currently, we have two different return signatures:
I'm considering unifying these to always return Get(index, key) *Entry
GetAll(index, key) []Entry Potential benefits:
Would love to hear thoughts on which API style you prefer and why. Current API: // Current Get returns (object, id)
obj, id := collection.Get("name", "Alice")
// Current GetAll returns ([]Entry, bool)
entries, ok := collection.GetAll("tags", "developer") Alternative API: // Alternative: Get returns Entry (with embedded ID and Obj)
entry := collection.Get("name", "Alice")
if entry != nil {
// Use entry.ID and entry.Obj
}
// Alternative: GetAll returns []Entry
entries := collection.GetAll("tags", "developer") |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: moul <[email protected]>
Addresses #1467
Related with #3317