Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add p/demo/avl/rotree #3317

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Conversation

moul
Copy link
Member

@moul moul commented Dec 10, 2024

Context: #3166 (comment)

@moul moul self-assigned this Dec 10, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 10, 2024
@moul moul mentioned this pull request Dec 10, 2024
6 tasks
@moul moul marked this pull request as ready for review December 10, 2024 16:21
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 10, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

moul added 2 commits December 10, 2024 20:10
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 11, 2024
@leohhhn leohhhn requested a review from ajnavarro December 17, 2024 11:26
@moul
Copy link
Member Author

moul commented Dec 17, 2024

I clicked on "SKIP" because the bot is unnecessarily suggesting an update to the base branch, which makes no sense for PRs only adding a new ./examples entry. I still believe the bot should either issue a warning about this or simply ignore it altogether.

cc @aeddi @thehowl

Edit: #3238 (comment)

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need this asap, will merge after CI.

examples/gno.land/p/demo/avl/pager/pager.gno Show resolved Hide resolved
@leohhhn leohhhn merged commit a7fdd70 into gnolang:master Dec 18, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in focus Core team is prioritizing this work 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants