Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve tests #1232

Merged
merged 3 commits into from
Oct 11, 2023
Merged

chore: improve tests #1232

merged 3 commits into from
Oct 11, 2023

Conversation

moul
Copy link
Member

@moul moul commented Oct 11, 2023

@gfanton, could you assist in integrating the new gnoland/pkg/integration package you created into gno.land/cmd/gnoweb/*_test.go? Please remove my t.Skip() as well.

Additionally, it seems that the CI was not testing gnoweb or running a gnoland node to ensure its functionality. We should review the configuration to determine if it is adequate or requires improvement.

@moul moul self-assigned this Oct 11, 2023
@moul moul changed the title dev/moul/fix tests chore: improve tests Oct 11, 2023
@moul moul marked this pull request as ready for review October 11, 2023 09:36
@moul moul requested a review from a team as a code owner October 11, 2023 09:36
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 11, 2023
@moul moul requested a review from gfanton October 11, 2023 09:42
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e144d26) 47.80% compared to head (02896cf) 47.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
- Coverage   47.80%   47.75%   -0.06%     
==========================================
  Files         369      369              
  Lines       62710    62710              
==========================================
- Hits        29981    29948      -33     
- Misses      30308    30330      +22     
- Partials     2421     2432      +11     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve after removing the t.Skip

@gfanton gfanton merged commit b34816b into gnolang:master Oct 11, 2023
177 checks passed
thehowl pushed a commit to thehowl/gno that referenced this pull request Oct 21, 2023
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants