-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve tests #1232
Merged
Merged
chore: improve tests #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
8 tasks
github-actions
bot
added
the
📦 ⛰️ gno.land
Issues or PRs gno.land package related
label
Oct 11, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
- Coverage 47.80% 47.75% -0.06%
==========================================
Files 369 369
Lines 62710 62710
==========================================
- Hits 29981 29948 -33
- Misses 30308 30330 +22
- Partials 2421 2432 +11 ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve after removing the t.Skip
This reverts commit f533cae.
gfanton
approved these changes
Oct 11, 2023
thehowl
pushed a commit
to thehowl/gno
that referenced
this pull request
Oct 21, 2023
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r/manfred/home
#1138).chore: Temporarily disable malfunctioning tests (discovered by Jae, who manually executedmake test
locally without a gnoland node running).@gfanton, could you assist in integrating the new
gnoland/pkg/integration
package you created intogno.land/cmd/gnoweb/*_test.go
? Please remove myt.Skip()
as well.Additionally, it seems that the CI was not testing
gnoweb
or running agnoland
node to ensure its functionality. We should review the configuration to determine if it is adequate or requires improvement.