Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce personal realms, add r/manfred/home #1138

Merged
merged 15 commits into from
Nov 23, 2023

Conversation

moul
Copy link
Member

@moul moul commented Sep 16, 2023

  • Added Manfred's personal dashboard (WIP), serving as an inaugural example of individual realms.
  • Updated examples/README.md to provide guidelines on the inclusion of personal realms and the continued emphasis on shared content.
  • This update paves the way for more personal realms, while maintaining a primary focus on shared, community-driven content.

Embeds #1232


Generated markdown...

Manfred's (gn)home Dashboard

Meme

Status

Online

Personal ToDo List

  • fill this todo list...

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@moul moul self-assigned this Sep 16, 2023
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 16, 2023
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 16, 2023
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98f384e) 55.93% compared to head (dfd2e3b) 55.20%.
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   55.93%   55.20%   -0.74%     
==========================================
  Files         420      421       +1     
  Lines       65415    66853    +1438     
==========================================
+ Hits        36592    36907     +315     
- Misses      25966    27072    +1106     
- Partials     2857     2874      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul changed the title feat: add r/manfred feat: introduce personal realms, add r/manfred/home Sep 16, 2023
@moul moul force-pushed the dev/moul/manfred-personal branch 2 times, most recently from 8c9853e to 7414258 Compare September 16, 2023 22:10
Signed-off-by: Manfred Touron <[email protected]>
@moul moul force-pushed the dev/moul/manfred-personal branch from 7414258 to 7c35321 Compare September 16, 2023 22:12
@moul moul marked this pull request as ready for review September 16, 2023 22:17
@moul moul requested a review from a team as a code owner September 16, 2023 22:17
@moul
Copy link
Member Author

moul commented Sep 16, 2023

Red CI, see #1139.

Edit: fixed. Or not?

@leohhhn
Copy link
Contributor

leohhhn commented Sep 19, 2023

Hello, I've a few questions.

Who will be allowed to have personal realms? Will adding new personal realms be permissionless for all GnoLand users, or based on PRs/contributions? If it will be permissionless, do we have any implementation plans for access control on the path level (who can deploy to which paths), as it would be prone to spam?

Just trying to understand the concept. I apologize if this is not the right place for this discussion.

@moul
Copy link
Member Author

moul commented Sep 20, 2023

TLDR:

  • The feature under discussion will be active on gno.land but might not be present on other associated blockchains.
  • The goal is to emulate GitHub's user and organization structure for contract publishing.
  • Contract registration is blockchain-based and relies on a contract for filtering.
  • Different registration mechanisms may be used for different namespaces. There's a suggestion for fee-based registration, with potential leniency during testing phases.
  • Contract publishing won't be limited to only approved users. Mainly, preferred URLs are being provided for them, with options for teams to share a namespace.
  • Non-official contracts can be published under a specific path.
  • Team functionalities need initial support; currently, namespaces are created by an admin but can transition to a team.
  • Additional discussions and implementations are ongoing in specific GitHub issues and pull requests.

For a more detailed explanation, please check the full discussion on #1107.

@moul
Copy link
Member Author

moul commented Oct 3, 2023

I'm adding this to portal loop #1108 because experimenting with personal things in our realm/namespace will become more common.

@moul
Copy link
Member Author

moul commented Oct 11, 2023

See also: #1224

examples/README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 11, 2023
@moul
Copy link
Member Author

moul commented Oct 11, 2023

I made a patch to ensure your test always works, even if we update the examples/ folder. We should focus on making it easier to write and maintain new tests. You can find the patch here: 1fc5600 (#1138).

This was referenced Oct 11, 2023
@github-actions github-actions bot removed the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 28, 2023
@moul
Copy link
Member Author

moul commented Oct 28, 2023

We now have r/manfred/present realm published during the portal loop initiative.

This PR’s main goal is now to review the examples/README.md.

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for gno-docs2 canceled.

Name Link
🔨 Latest commit 381fe8b
🔍 Latest deploy log https://app.netlify.com/sites/gno-docs2/deploys/654e6227de0aa1000923d3ed

Signed-off-by: moul <[email protected]>
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gfanton gfanton merged commit ebe47db into gnolang:master Nov 23, 2023
184 of 185 checks passed
gfanton pushed a commit to moul/gno that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Status: 🌟 Wanted for Launch
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants