Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧🚇 Only run check-maifest on the CI #967

Merged
merged 2 commits into from
Jan 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/CI_CD_actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,21 @@ jobs:
- name: Run pre-commit
uses: pre-commit/[email protected]

check-manifest:
name: Check Manifest
runs-on: ubuntu-latest
steps:
- name: Check out repo
uses: actions/checkout@v2
- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
python-version: 3.8
- name: Install check manifest
run: python -m pip install check-manifest
- name: Run check manifest
run: check-manifest

docs:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -88,7 +103,7 @@ jobs:

test:
runs-on: ${{ matrix.os }}
needs: pre-commit
needs: [pre-commit, check-manifest]
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macOS-latest]
Expand Down
5 changes: 0 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,3 @@ repos:
types: [file]
types_or: [python, pyi, markdown, rst, jupyter]
args: [-L doas]

- repo: https://github.com/mgedmin/check-manifest
rev: "0.47"
hooks:
- id: check-manifest
3 changes: 2 additions & 1 deletion changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
### 🚧 Maintenance

- 🔧 Improve packaging tooling (#923)
🔧🚇 Exclude test files from duplication checks on sonarcloud (#959)
- 🔧🚇 Exclude test files from duplication checks on sonarcloud (#959)
- 🔧🚇 Only run check-maifest on the CI #967

## 0.5.1 (2021-12-31)

Expand Down