-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧🚇 Only run check-maifest on the CI #967
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Benchmark is done. Checkout the benchmark result page. Benchmark diff v0.5.1 vs. mainParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
Benchmark diff main vs. PRParametrized benchmark signatures: BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)
|
Codecov Report
@@ Coverage Diff @@
## main #967 +/- ##
=====================================
Coverage 85.3% 85.3%
=====================================
Files 90 90
Lines 4859 4859
Branches 913 913
=====================================
Hits 4149 4149
Misses 561 561
Partials 149 149 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. 👍
While it is important that we check if all files we want to bundle are actually bundled in the distribution, checking this in pre-commit can be cumbersome.
E.g. you were working on a PR and when you got it to work the way you want you to commit different small changes in contextual closed commits. If you added new files which you don't want to add in this commit
check-manifest
won't allow you to make this commit since it looks at all files and not only the tracked ones.This in turn means that you need to make big commits or use the
--no-verify
flag which both can lead to bad commits.Change summary
Checklist