Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming parameter package from "csv" to "pandas" #844 #895

Closed
wants to merge 3 commits into from
Closed

renaming parameter package from "csv" to "pandas" #844 #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89ac4a1
renaming parameter package from "csv" to "pandas"
patrickhaetti Nov 8, 2021
866004e
Merge remote-tracking branch 'origin/rename-csv-parameter-package-to-…
patrickhaetti Nov 8, 2021
dc91148
change csv to pandas
patrickhaetti Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ LICENSE @glotaran/pyglotaran_creators
# builtin module:
/glotaran/builtin/io/* @glotaran/admins
/glotaran/builtin/io/ascii @jsnel @glotaran/maintainers
/glotaran/builtin/io/csv @glotaran/maintainers
/glotaran/builtin/io/pandas @glotaran/maintainers
/glotaran/builtin/io/netCDF @glotaran/maintainers
/glotaran/builtin/io/sdt @glotaran/maintainers
/glotaran/builtin/megacomplexes/ @jsnel @joernweissenborn
Expand Down
0 glotaran/builtin/io/csv/__init__.py → glotaran/builtin/io/pandas/__init__.py
View file
Open in desktop
File renamed without changes.
0 glotaran/builtin/io/csv/csv.py → glotaran/builtin/io/pandas/csv.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions glotaran/plugin_system/test/test_project_io_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import pytest

from glotaran.builtin.io.csv.csv import CsvProjectIo
from glotaran.builtin.io.pandas.csv import CsvProjectIo
from glotaran.builtin.io.yml.yml import YmlProjectIo
from glotaran.io import ProjectIoInterface
from glotaran.parameter import ParameterGroup
Expand Down Expand Up @@ -194,7 +194,7 @@ def test_known_project_format_actual_register():
assert is_known_project_format("glotaran.builtin.io.yml.yml.YmlProjectIo_yml")
assert is_known_project_format("glotaran.builtin.io.yml.yml.YmlProjectIo_yaml")
assert is_known_project_format("glotaran.builtin.io.yml.yml.YmlProjectIo_yml_str")
assert is_known_project_format("glotaran.builtin.io.csv.csv.CsvProjectIo_csv")
assert is_known_project_format("glotaran.builtin.io.pandas.csv.CsvProjectIo_csv")


@pytest.mark.parametrize(
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ glotaran.plugins.megacomplexes =
spectral = glotaran.builtin.megacomplexes.spectral
glotaran.plugins.project_io =
yml = glotaran.builtin.io.yml.yml
csv = glotaran.builtin.io.csv.csv
csv = glotaran.builtin.io.pandas.csv
folder = glotaran.builtin.io.folder.folder_plugin

[aliases]
Expand Down