Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming parameter package from "csv" to "pandas" #844 #895

Conversation

patrickhaetti
Copy link
Contributor

@patrickhaetti patrickhaetti commented Nov 8, 2021

Change summary

  • Renaming the parameter package folder as part of ✨ Support all everything what pandas dataframe supports for parameter io #844
  • renamed glotaran.builtin.io.csv to glotaran.builtin.io.pandas
  • setup.cfg: rename csv = glotaran.builtin.io.csv.csv to csv = glotaran.builtin.io.pandas.csv
  • updated test_project_io_registration.py
  • .github/CODEOWNERS: change /glotaran/builtin/io/csv to /glotaran/builtin/io/pandas

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 👌 Closes issue (mandatory for ✨ feature and 🩹 bug fix PR's)
  • 🧪 Adds new tests for the feature (mandatory for ✨ feature and 🩹 bug fix PR's)
  • 📚 Adds documentation of the feature

	*renamed folder glotaran.builtin.io.csv to glotaran.builtin.io.pandas
	*updated setup.cfg
	*updated test_project_io_registration.py
@patrickhaetti patrickhaetti requested review from s-weigand and a team as code owners November 8, 2021 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

Binder 👈 Launch a binder notebook on branch patrickhaetti/pyglotaran/rename-csv-parameter-package-to-pandas-844

@s-weigand
Copy link
Member

@patrickhaetti Don't just close a PR, only because one CI job failed, we are here to help you 😉

@patrickhaetti
Copy link
Contributor Author

@patrickhaetti Don't just close a PR, only because one CI job failed, we are here to help you wink

thank you, I will reopen it

@patrickhaetti patrickhaetti reopened this Nov 8, 2021
…pandas-844' into rename-csv-parameter-package-to-pandas-844
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #895 (dc91148) into main (efc333a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #895   +/-   ##
=====================================
  Coverage   84.7%   84.7%           
=====================================
  Files         81      81           
  Lines       4596    4596           
  Branches     849     849           
=====================================
  Hits        3897    3897           
  Misses       558     558           
  Partials     141     141           
Impacted Files Coverage Δ
glotaran/builtin/io/pandas/csv.py 100.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc333a...dc91148. Read the comment docs.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 8, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.11 ⭐ 0.11 ⭐ 0.00
Method Length 33.62 ⭐ 33.62 ⭐ 0.00
Working memory 4.11 ⭐ 4.11 ⭐ 0.00
Quality 91.22% 91.22% 0.00%
Other metrics Before After Change
Lines 340 340 0
Changed files Quality Before Quality After Quality Change
glotaran/plugin_system/test/test_project_io_registration.py 91.22% ⭐ 91.22% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s-weigand
Copy link
Member

Closing on favor of #896

@s-weigand s-weigand closed this Nov 10, 2021
@patrickhaetti patrickhaetti deleted the rename-csv-parameter-package-to-pandas-844 branch November 19, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants