Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Issues with normalization of traces when fitting multiple datasets #1157

Closed
jsnel opened this issue Nov 2, 2022 · 1 comment · Fixed by #1156
Closed

🐛 Issues with normalization of traces when fitting multiple datasets #1157

jsnel opened this issue Nov 2, 2022 · 1 comment · Fixed by #1156
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns

Comments

@jsnel
Copy link
Member

jsnel commented Nov 2, 2022

Version information

  • pyglotaran version: main (v0.7.0-dev)
  • contributor: @ism200

Describe the bug

In a (fairly) complex fit of multiple datasets the scaling of fitted traces appears to be incorrect, as judged by domain expert @ism200 using timu as reference,

Should look like this:
image
image

But looks like this instead:
image
image

To Reproduce

(Can only be reproduced internally, internal reference: PSI_7335_7521WLproject)
@jsnel jsnel added the Type: Bug Minor issues, non-crashing bug, slowdowns label Nov 2, 2022
@jsnel jsnel mentioned this issue Nov 2, 2022
Merged
3 tasks
@jsnel
Copy link
Member Author

jsnel commented Nov 2, 2022

Update after reviewing resulting from PR #1156

795

image
compared to
image

704

image
compared to
image

Looks good!

jsnel added a commit to ism200/pyglotaran that referenced this issue Nov 2, 2022
@jsnel
📚 Add change to changelog
b396463 
Bugfix of issues glotaran#1157 (originally reported by e-mail Nov 1st, 2022)
jsnel added a commit that referenced this issue Nov 2, 2022
@ism200 @jsnel
fix bug in irf normalization (added an "s" after irfscale) (#1156)
c8d7722 
Bug fix of issue filed under #1157 (originally reported by Ivo by e-mail Nov 1st, 2022)

* fix bug in irf normalization (added an "s" after irfscale)
* 📚 Add change to changelog

Co-authored-by: Ivo van Stokkum <[email protected]>
Co-authored-by: Joris Snellenburg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug in irf normalization (added an "s" after irfscale) ism200/pyglotaran
1 participant
@jsnel