Skip to content

Commit

Permalink
fix bug in irf normalization (added an "s" after irfscale) (#1156)
Browse files Browse the repository at this point in the history
Bug fix of issue filed under #1157 (originally reported by Ivo by e-mail Nov 1st, 2022)

* fix bug in irf normalization (added an "s" after irfscale)
* 📚 Add change to changelog

Co-authored-by: Ivo van Stokkum <[email protected]>
Co-authored-by: Joris Snellenburg <[email protected]>
  • Loading branch information
3 people authored Nov 2, 2022
1 parent f8dc527 commit c8d7722
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
### 🩹 Bug fixes

- 🩹 Fix result data overwritten when using multiple dataset_groups (#1147)
- 🩹 Fix for normalization issue described in #1157 (multi-gaussian irfs and multiple time ranges (streak))

### 📚 Documentation

Expand Down
2 changes: 1 addition & 1 deletion glotaran/builtin/megacomplexes/decay/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def decay_matrix_implementation(
backsweep_period,
)
if dataset_model.irf.normalize:
matrix /= np.sum(irf_scale)
matrix /= np.sum(irf_scales)

else:
calculate_decay_matrix_no_irf(matrix, rates, model_axis)
Expand Down

0 comments on commit c8d7722

Please sign in to comment.