Re-enable support for extra args in EP config models #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmello
requested review from
yadudoc,
ryanchard,
chris-janidlo,
joshbryan-globus,
khk-globus and
LeiGlobus
A recent PR removed the `extra = "allow"` attribute from the `BaseConfigModel` Pydantic class. Many subclass models rely on this setting to permit required arguments without rasing a `ValidationError`.
rjmello
force-pushed
the
fix-config-model-extra-args
branch
from
f96f819 to
0176092
Compare
khk-globus
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1708 removed the
extra = "allow"attribute from theBaseConfigModelPydantic class. Many subclass models rely on this setting to permit required arguments without rasing aValidationError.Type of change