Separate MultiUser configuration #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
the
no-news-is-good-news
rjmello
reviewed
Nov 6, 2024
compute_endpoint/globus_compute_endpoint/endpoint/config/model.py
Outdated
Show resolved
Hide resolved
khk-globus
force-pushed
the
sc-37362/create_templateconfig
branch
from
0839cab to
38e2577
Compare
rjmello
reviewed
Nov 7, 2024
compute_endpoint/globus_compute_endpoint/endpoint/config/utils.py
Outdated
Show resolved
Hide resolved
compute_endpoint/globus_compute_endpoint/endpoint/config/config.py
Outdated
Show resolved
Hide resolved
compute_endpoint/globus_compute_endpoint/endpoint/config/config.py
Outdated
Show resolved
Hide resolved
compute_endpoint/globus_compute_endpoint/endpoint/config/config.py
Outdated
Show resolved
Hide resolved
compute_endpoint/globus_compute_endpoint/endpoint/config/config.py
Outdated
Show resolved
Hide resolved
compute_endpoint/globus_compute_endpoint/endpoint/config/model.py
Outdated
Show resolved
Hide resolved
khk-globus
force-pushed
the
sc-37362/create_templateconfig
branch
from
3174b48 to
7a6adbc
Compare
To date, we've been comingling the MEP and UEP configurations in `Config`. At this time, the two implementations are starting to diverge in their overlap, so bite the bullet and be clear about the differences. This implementation uses `BaseConfig` for the shared attributes, maintains `Config` for backward compatability, and introduces `UserEndpointConfig` for the user endpoint and `ManagerEndpointConfig` for the endpoint manager configuration. The core of the changes start in `endpoint/config/config.py`, where `UserEndpointConfig` (for UEPs) and `ManagerEndpointConfig` (for MEPs) are defined. These are backed up by requisite changes to the Pydantic model in `config/model.py`, Just about every other change is in support of the now-distinct configuration classes. Notes: - test coverage has increased around the configurations - the YAML facade shouldn't change at all from the user perspective. This is an internal organization detail [sc-37362]
khk-globus
force-pushed
the
sc-37362/create_templateconfig
branch
from
7a6adbc to
9f1408a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To date, we've been comingling the MEP and UEP configurations in
Config. At this time, the two implementations are starting to diverge in their overlap, so bite the bullet and be clear about the differences. This implementation usesBaseConfigfor the shared attributes, maintainsConfigfor backward compatability, and introducesUserEndpointConfigfor the user endpoint andManagerEndpointConfigfor the endpoint manager configuration.The core of the changes start in
endpoint/config/config.py, whereUserEndpointConfig(for UEPs) andManagerEndpointConfig(for MEPs) are defined. These are backed up by requisite changes to the Pydantic model inconfig/model.py, Just about every other change is in support of the now-distinct configuration classes.Notes:
[sc-37362]
Type of change