Date: Add formatDateToParts #700

rxaviers · 2017-03-03T22:17:13Z

Supersedes #697, Fixes #678

List of part types, its respective CLDR date fields, and comparison with Intl DateTimeFormat formatToParts.

Globalize	CLDR date fields	Intl formatToParts
era	era	era
year	year	year
quarter	quarter	-
month	month	month
week	week	-
day	day	day
weekday	weekday	weekday
dayperiod	dayperiod	dayPeriod
hour	hour	hour
minute	minute	minute
second	second	second
zone	zone	timeZoneName
literal	literal	literal

List of part types and the corresponding CLDR date field patterns.

part type	CLDR date field	CLDR date field patterns
era	era	G
year	year	yY
quarter	quarter	qQ
month	month	ML
week	week	wW
day	day	dDF
weekday	weekday	ecE
dayperiod	dayperiod	a
hour	hour	hHkK
minute	minute	m
second	second	sSA
zone	zone	zOxX
literal	literal

Checklist:
Checklist

jsf-clabot · 2017-03-14T21:46:23Z

All committers have signed the CLA.

jzaefferer

I started reviewing, then got dragged into a meeting. Didn't get very far, but hopefully the existing comments will help.

jzaefferer · 2017-04-11T13:35:12Z

doc/api/date/date-formatter.md

@@ -89,7 +89,7 @@ var enFormatter = Globalize( "en" ).dateFormatter(),
  deFormatter = Globalize( "de" ).dateFormatter();

 enFormatter( new Date( 2010, 10, 30, 17, 55 ) );
-// > "11/30/2010, 5:55 PM"
+// > "11/30/2010"


Should the line above still pass the time to the Date constructor? Probably applies to various other examples in this file (and others?) as well.

The time part of the Date constructor is irrelevant and could be removed. 👍

jzaefferer · 2017-04-11T13:37:01Z

doc/api/date/date-to-parts-formatter.md

+
+### Example
+
+Prior to using any date methods, you must load


Do all docs have this note in the example section? Seems like important information that could be pulled up.

Yeap, other modules/fns have the same statement.

jzaefferer · 2017-04-11T13:38:07Z

doc/api/date/date-to-parts-formatter.md

+formatter( new Date( 2010, 10, 30, 17, 55 ) ).map(({type, value}) => {
+  switch ( type ) {
+    case "year": return `<strong>${value}</strong>`;
+    default : return value;


misplaced space in front of the colon

Thx a9bc0b5

jzaefferer · 2017-04-11T13:39:04Z

doc/api/date/date-to-parts-formatter.md

+
+- `day`
+
+  The string used for the day, e.g., `"17"`, `"١٦"`.


Could compress this section a lot by putting the type of description on one line.

- `day`: The string used for the day, e.g., `"17"`, `"١٦"`.

Yeap, I think it needs overall improvement. I dislike the current format of the API, I am wondering if we had something like https://github.com/rxaviers/relative-time#formatdate-options instead.

Let's track overall docs improvement in a separate PR.

jzaefferer · 2017-04-11T13:40:29Z

doc/api/date/date-to-parts-formatter.md

+Globalize.locale( "en" );
+formatter = Globalize.dateToPartsFormatter();
+
+formatter( new Date( 2010, 10, 30, 17, 55 ) ).map(({type, value}) => {


This is a great example, but it doesn't output the time, which seems harder to implement, since a join("") wouldn't be enough. Would be great to have an example including time.

since a join("") wouldn't be enough

Why? Check the parts output of a date and time case https://github.com/globalizejs/globalize/pull/700/files#diff-5e625c00d307f2b886e1b33225953053R165

Having said that, I think it's valid to include a date and time example.

rxaviers · 2017-04-12T22:50:47Z

@jzaefferer thanks for your review

rxaviers · 2017-04-12T22:56:48Z

examples/app-npm-webpack/messages/es.json

@@ -4,6 +4,7 @@
 		"number-label": "Número",
 		"currency-label": "Moneda",
 		"date-label": "Fecha",
+		"date-to-parts-label": "Fecha (note el mes destacado en negro, el marcador de html se agregó utilizando dateToPartsFormatter)",


Thanks @lwelti

rxaviers · 2017-04-12T22:56:58Z

examples/app-npm-webpack/messages/de.json

@@ -4,6 +4,7 @@
 		"number-label": "Zahl",
 		"currency-label": "Währung",
 		"date-label": "Datum",
+		"date-to-parts-label": "Datum (beachten Sie den hervorgehobenen Monat, das Markup wurde mit dateToPartsFormatter hinzugefügt)",


Thanks @jzaefferer

Ref globalizejs#678 Ref globalizejs#697 Ref globalizejs#700

Fixes globalizejs#678 Closes globalizejs#697 Closes globalizejs#700

When dateToPartsFormatter was added, dateFormatter became an alias to it. Although globalize-compiler can handle it by using `.compileExtracts()`, it doesn't by using `.compile()` and passing `formattersAndParsers` argument. This update fixed that. Amends e4234a7 Ref globalizejs#678 Ref globalizejs#697 Ref globalizejs#700

rxaviers mentioned this pull request Mar 3, 2017

Date: Add formatDateToParts #697

Closed

rxaviers force-pushed the date-to-parts-2 branch from 1b039ba to 5ee25cb Compare March 3, 2017 22:18

rxaviers mentioned this pull request Mar 8, 2017

Date: Olson-timezone-support (real 'z', 'v', 'V') and options.timeZone #701

Closed

13 tasks

rxaviers force-pushed the date-to-parts-2 branch 2 times, most recently from 9a1b387 to 1cd9bd4 Compare March 14, 2017 21:46

rxaviers added this to the 1.3.0 milestone Mar 17, 2017

rxaviers force-pushed the date-to-parts-2 branch from 1cd9bd4 to 6118055 Compare March 17, 2017 13:48

rxaviers force-pushed the date-to-parts-2 branch 2 times, most recently from ff349bd to c11b38a Compare April 11, 2017 13:35

jzaefferer reviewed Apr 11, 2017

View reviewed changes

rxaviers force-pushed the date-to-parts-2 branch 2 times, most recently from d9b8c40 to 9408bff Compare April 12, 2017 22:55

rxaviers commented Apr 12, 2017

View reviewed changes

rpayami and others added 3 commits April 12, 2017 19:58

Date: Add formatDateToParts (1/2)

6919f43

Ref globalizejs#678 Ref globalizejs#697 Ref globalizejs#700

Date: Add formatDateToParts (2/2)

e4234a7

Fixes globalizejs#678 Closes globalizejs#697 Closes globalizejs#700

Example: Update translations based on Google Translate

8eed86d

rxaviers force-pushed the date-to-parts-2 branch from 9408bff to 8eed86d Compare April 12, 2017 22:59

rxaviers merged commit 8eed86d into globalizejs:master Apr 12, 2017

rxaviers deleted the date-to-parts-2 branch April 12, 2017 23:37

rxaviers mentioned this pull request May 17, 2017

Date: Fix dateFormatter runtime #724

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Date: Add formatDateToParts #700

Date: Add formatDateToParts #700

rxaviers commented Mar 3, 2017 •

edited

Loading

jsf-clabot commented Mar 14, 2017 •

edited

Loading

jzaefferer left a comment

jzaefferer Apr 11, 2017

rxaviers Apr 11, 2017

rxaviers Apr 12, 2017

jzaefferer Apr 11, 2017

rxaviers Apr 11, 2017 •

edited

Loading

jzaefferer Apr 11, 2017

rxaviers Apr 12, 2017

jzaefferer Apr 11, 2017

rxaviers Apr 11, 2017

rxaviers Apr 12, 2017

jzaefferer Apr 11, 2017

rxaviers Apr 11, 2017 •

edited

Loading

rxaviers Apr 12, 2017

rxaviers commented Apr 12, 2017

rxaviers Apr 12, 2017

rxaviers Apr 12, 2017

Date: Add formatDateToParts #700

Date: Add formatDateToParts #700

Conversation

rxaviers commented Mar 3, 2017 • edited Loading

jsf-clabot commented Mar 14, 2017 • edited Loading

jzaefferer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rxaviers Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rxaviers Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rxaviers commented Apr 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rxaviers commented Mar 3, 2017 •

edited

Loading

jsf-clabot commented Mar 14, 2017 •

edited

Loading

rxaviers Apr 11, 2017 •

edited

Loading

rxaviers Apr 11, 2017 •

edited

Loading