Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date: Add formatDateToParts #697

Closed
wants to merge 1 commit into from

Conversation

rpayami
Copy link
Contributor

@rpayami rpayami commented Mar 1, 2017

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented Mar 1, 2017

CLA assistant check
All committers have signed the CLA.

@rxaviers
Copy link
Member

rxaviers commented Mar 3, 2017

Thank you @rpayami! Continuing your work on #700.

@rxaviers rxaviers closed this Mar 3, 2017
@rxaviers rxaviers mentioned this pull request Mar 17, 2017
23 tasks
rxaviers pushed a commit to rxaviers/globalize that referenced this pull request Apr 12, 2017
rxaviers added a commit to rxaviers/globalize that referenced this pull request Apr 12, 2017
rxaviers added a commit to rxaviers/globalize that referenced this pull request May 17, 2017
When dateToPartsFormatter was added, dateFormatter became an alias to
it. Although globalize-compiler can handle it by using
`.compileExtracts()`, it doesn't by using `.compile()` and passing
`formattersAndParsers` argument. This update fixed that.

Amends e4234a7
Ref globalizejs#678
Ref globalizejs#697
Ref globalizejs#700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants