Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation restructuring #636

Merged
merged 13 commits into from
Oct 26, 2020
Merged

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Oct 23, 2020

Summary

Areas to test

  • Send normal message
  • Signup as a beneficiary, it should automatically display in the conversation list
  • Messages should be updated in realtime
  • Load more conversations
  • Load more messages

Test Plan

  • Included in the PR

@kurund kurund added this to the v0.6 milestone Oct 23, 2020
@kurund kurund linked an issue Oct 23, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #636 into master will increase coverage by 0.02%.
The diff coverage is 17.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   73.94%   73.97%   +0.02%     
==========================================
  Files         133      134       +1     
  Lines        2990     2997       +7     
  Branches      587      587              
==========================================
+ Hits         2211     2217       +6     
- Misses        571      573       +2     
+ Partials      208      207       -1     
Impacted Files Coverage Δ
src/containers/Chat/Chat.tsx 71.60% <0.00%> (+4.93%) ⬆️
...onversations/ConversationList/ConversationList.tsx 55.35% <0.00%> (+1.90%) ⬆️
src/containers/Chat/ChatMessages/ChatMessages.tsx 58.06% <0.00%> (ø)
src/containers/Group/GroupList/GroupList.tsx 55.05% <0.00%> (-0.63%) ⬇️
src/services/ChatService.ts 25.00% <25.00%> (ø)
src/components/UI/Timer/Timer.tsx 77.27% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca2e71...a658d94. Read the comment docs.

@kurund kurund self-assigned this Oct 25, 2020
@kurund kurund requested a review from rathorevaibhav October 25, 2020 18:39
@kurund kurund marked this pull request as ready for review October 25, 2020 18:39
Copy link
Contributor

@rathorevaibhav rathorevaibhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rathorevaibhav rathorevaibhav merged commit 9027d27 into master Oct 26, 2020
@rathorevaibhav rathorevaibhav deleted the conversation-restructuring branch October 26, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants