Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving message subscription logic to a higher order component? #454

Closed
rathorevaibhav opened this issue Sep 10, 2020 · 1 comment · Fixed by #658
Closed

Moving message subscription logic to a higher order component? #454

rathorevaibhav opened this issue Sep 10, 2020 · 1 comment · Fixed by #658
Assignees
Milestone

Comments

@rathorevaibhav
Copy link
Contributor

Describe the task
Currently, the logic for the subscription of a message is written in the chat component. So if we move out of that component we do not receive any message updates on any other screen.

Expected behavior
We can move this logic to a HOC so that we get notified of a new message on the whole application. We will receive message updates even when we are on any screen other than chat.

@rathorevaibhav rathorevaibhav added the question Further information is requested label Sep 10, 2020
@kurund
Copy link
Contributor

kurund commented Sep 10, 2020

@rathorevaibhav Yes, I agree. It was in my list of things to do in 0.4 :) Not only subscription but the entire logic of conversations management should be moved out. We should move it to the service instead of HOC. Everyone just calls the service and get the required information and also update the same using subscription.

@rathorevaibhav rathorevaibhav removed the question Further information is requested label Sep 14, 2020
@kurund kurund self-assigned this Oct 11, 2020
@kurund kurund added this to the v0.5.2 milestone Oct 20, 2020
@kurund kurund linked a pull request Oct 23, 2020 that will close this issue
5 tasks
@kurund kurund removed a link to a pull request Oct 25, 2020
5 tasks
@kurund kurund modified the milestones: v0.5.2, v0.6 Oct 25, 2020
@kurund kurund linked a pull request Oct 30, 2020 that will close this issue
@kurund kurund modified the milestones: v0.6.0, v0.6.1 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants