Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saved search contact view fixes #2232

Merged
merged 1 commit into from
Nov 21, 2022
Merged

saved search contact view fixes #2232

merged 1 commit into from
Nov 21, 2022

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Nov 18, 2022

No description provided.

@kurund kurund linked an issue Nov 18, 2022 that may be closed by this pull request
@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request November 18, 2022 00:08 Inactive
@kurund kurund requested a review from mdshamoon November 18, 2022 00:10
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 70.42% // Head: 70.39% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (08fed68) compared to base (b5e4d1e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
- Coverage   70.42%   70.39%   -0.04%     
==========================================
  Files         238      238              
  Lines        8065     8065              
  Branches     1734     1734              
==========================================
- Hits         5680     5677       -3     
- Misses       1801     1805       +4     
+ Partials      584      583       -1     
Impacted Files Coverage Δ
...c/routes/AuthenticatedRoute/AuthenticatedRoute.tsx 76.47% <ø> (ø)
...c/containers/NotificationList/NotificationList.tsx 80.00% <0.00%> (-3.64%) ⬇️
src/containers/Flow/FlowList/FlowList.tsx 71.66% <0.00%> (-1.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Nov 18, 2022



Test summary

172 0 0 0Flakiness 1


Run details

Project Glific
Status Passed
Commit a61d9bc ℹ️
Started Nov 18, 2022 12:17 AM
Ended Nov 18, 2022 12:37 AM
Duration 19:30 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/roles/staff/contactBar/ContactBar.spec.ts Flakiness
1 Role - Staff - Contact bar > should add to collection

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kurund kurund merged commit e3b3a56 into master Nov 21, 2022
@kurund kurund deleted the saved-search-fixes branch November 21, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to open contacts chat after searching it from saved searches
1 participant