Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with saving credentials #2016

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Fix issues with saving credentials #2016

merged 2 commits into from
Apr 13, 2022

Conversation

mdshamoon
Copy link
Member

Summary

Fix issues with saving credentials

@mdshamoon mdshamoon linked an issue Apr 7, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

@github-actions github-actions bot temporarily deployed to pull request April 7, 2022 05:47 Inactive
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #2016 (53bbc43) into master (a0c355f) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   76.08%   75.95%   -0.13%     
==========================================
  Files         216      216              
  Lines        7500     7507       +7     
  Branches     1621     1622       +1     
==========================================
- Hits         5706     5702       -4     
- Misses       1270     1281      +11     
  Partials      524      524              
Impacted Files Coverage Δ
src/containers/SettingList/Providers/Providers.tsx 95.00% <100.00%> (+0.47%) ⬆️
src/containers/Trigger/Trigger.tsx 77.68% <0.00%> (-4.14%) ⬇️
...rs/InteractiveMessage/InteractiveMessage.helper.ts 66.91% <0.00%> (-3.01%) ⬇️
src/containers/Template/List/Template.tsx 83.87% <0.00%> (-2.16%) ⬇️
src/containers/List/List.tsx 83.76% <0.00%> (-1.05%) ⬇️
src/containers/Form/FormLayout.tsx 64.31% <0.00%> (+0.46%) ⬆️
src/components/UI/Form/TimePicker/TimePicker.tsx 84.21% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c355f...53bbc43. Read the comment docs.

@cypress
Copy link

cypress bot commented Apr 7, 2022



Test summary

180 0 0 0Flakiness 3


Run details

Project Glific
Status Passed
Commit c0f08f4 ℹ️
Started Apr 7, 2022 5:56 AM
Ended Apr 7, 2022 6:21 AM
Duration 25:43 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

contactBar/ContactBar.spec.ts Flakiness
1 Contact bar > should add to collection
roles/staff/collection/Collection.spec.ts Flakiness
1 Role - Staff - Collection > should remove member from collection
staffmanagement/StaffManagement.spec.ts Flakiness
1 Staff Management > should save edit screen

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mdshamoon mdshamoon requested a review from kurund April 7, 2022 07:54
@mdshamoon mdshamoon self-assigned this Apr 7, 2022
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@github-actions github-actions bot temporarily deployed to pull request April 13, 2022 22:31 Inactive
@kurund kurund merged commit 271ec02 into master Apr 13, 2022
@kurund kurund deleted the bug/form-save branch April 13, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credentials need to be saved twice to show up in Glific
2 participants