gh-445: place all public function in __all__
#446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
commented
Nov 21, 2024
| @@ -19,7 +19,6 @@ | |||
| transform_cls, | |||
| ) | |||
| from glass.galaxies import ( | |||
| _kappa_ia_nla, | |||
There was a problem hiding this comment.
Makes sense to remove from here until it's time to tackle #411.
|
Excellent, sorry I missed that. Let's follow PEP8 and keep |
Always assumed it had to go after the imports, but clearly that isn't the case. Have changed. |
ntessore
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #445. Looks like this was missed in #221. All public functions need to be in all. This will address the comments from #442.