Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we fix the main namespace so that mypy understands what we are importing? #445

Closed
paddyroddy opened this issue Nov 21, 2024 · 0 comments · Fixed by #446
Closed

Should we fix the main namespace so that mypy understands what we are importing? #445

paddyroddy opened this issue Nov 21, 2024 · 0 comments · Fixed by #446
Assignees
@paddyroddy
Labels
bug Something isn't working

Comments

@paddyroddy
Copy link
Member

paddyroddy commented Nov 21, 2024 •
edited
Loading

Why does it need these type ignore? Should we fix the main namespace so that mypy understands what we are importing?

Originally posted by @ntessore in #442 (comment)
@paddyroddy paddyroddy added the bug Something isn't working label Nov 21, 2024
@paddyroddy paddyroddy changed the title Why does it need these type ignore? Should we fix the main namespace so that mypy understands what we are importing? Should we fix the main namespace so that mypy understands what we are importing? Nov 21, 2024
@paddyroddy paddyroddy self-assigned this Nov 21, 2024
This was referenced Nov 21, 2024
Merged
Merged
paddyroddy added a commit that referenced this issue Nov 21, 2024
@paddyroddy
gh-445: place all public function in __all__ (#446)
09b14bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-445: place all public function in __all__ glass-dev/glass
1 participant
@paddyroddy