-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into v1 #585
Merge main into v1 #585
Conversation
Check if on default branch before uploading database
Provide a better error message
Only attempt to upload on dotcom
Add a CODEOWNERS file
Upload CodeQL databases
Revert "Upload CodeQL databases"
Mergeback v1.0.2 refs/heads/v1 into main
Upload CodeQL databases - mk2
Update CodeQL bundle to 20210622 / 2.5.6
The changelog for an empty version will now be: ``` No user facing changes. ``` And this will appear in the final changelog when there is an actual release. The benefits are that users will see regular release cycles and know how old versions are even if there's no changes for a particular version If we find that we are going months without any user facing changes, but we have non-visible changes, then we can rethink this strategy. But I think this is nicer than having empty sections for a version.
Update changelog template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Was the decision to not include a changelog entry for uploading databases a deliberate one since external users do not have a use for this yet? Seems reasonable but just checking this isn't an accident.
It was a conscious choice since it's not a user-facing feature yet. See #573 (review) |
Ah good. Something went wrong and it didn't run any CI on that last commit. Closing and opening has prodded it into action. |
Merging d623a7a into v1
Conductor for this PR is @aeisenberg
Contains the following pull requests:
Please review the following: