Only attempt to upload on dotcom #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rneatherway
approved these changes
Jun 17, 2021
This was referenced Apr 24, 2023
This was referenced Apr 24, 2023
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note this is merging into a feature branch, and not into
main)Only attempt to do anything relating to uploading databases when running against github.com. Thankfully this information is already stored in the config so we can just check that.
Slightly related question, I've been adding these debug logs explaining why we're not uploading. Is that useful? Is it just going to get unnecessary questions about what this is? Not many people run with debug logs enabled, which both means not many people will see it but also it won't be useful to us unless specifically enabled.