Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools telemetry: accurately report when feature flags were inaccessible #1532

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

angelapwen
Copy link
Contributor

Merge / deployment checklist

Previously, we sent a false value of tools_feature_flags_valid in our status reports when we were actually unable to access our feature flags, for example in cases where the repository does not have the appropriate security permissions to access feature flags. This change should allow us to catch the error where we are unable to access feature flags, and not send the tools_feature_flags_valid field at all to the status report.

This will enable us to create a monitor on the tools_feature_flags_valid telemetry field, as we will always expect it to be 0.

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner February 9, 2023 01:53
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor comments.

src/feature-flags.ts Outdated Show resolved Hide resolved
src/feature-flags.ts Outdated Show resolved Hide resolved
@angelapwen angelapwen merged commit 40babc1 into github:main Feb 10, 2023
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
6 tasks
@angelapwen angelapwen deleted the telemetry-accessible-ff branch April 29, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants