-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max line length of 120 to linter #1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. My understanding is that the linting rules here are copied from gh/gh. I think it's generally ok to become stricter than gh/gh, but not more lenient. So, this PR LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps we can look to remove the ignore*
settings as we go forwards, but we should prioritize this alongside re-enabling the rules we disabled while transitioning to eslint at the bottom of the file.
aad52df
7f70608
to
aad52df
Compare
Had to rebase |
/** Whether the relevant tools dotcom feature flags have been misconfigured. | ||
* Only populated if we attempt to determine the default version based on the dotcom feature flags. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For next time (I don't think this is worth a recompiling and rerunning the checks for)
/** Whether the relevant tools dotcom feature flags have been misconfigured. | |
* Only populated if we attempt to determine the default version based on the dotcom feature flags. */ | |
/** | |
* Whether the relevant tools dotcom feature flags have been misconfigured. | |
* Only populated if we attempt to determine the default version based on the dotcom feature flags. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change in this PR: #1532
This change adds the
max-len
property to the linter, which will enforce a maximum of 120 characters per line. It also ignores URLs, strings, and template literals in case these cases exceed 120 characters.We also have the option to ignore all comments, or just trailing comments (https://eslint.org/docs/latest/rules/max-len). I have left those out for now but am open to adding them! The PR also fixes some comments that have exceeded the 120 character limit.
Merge / deployment checklist