Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR check to validate compatibility with Node 12 #1001

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Add PR check to validate compatibility with Node 12 #1001

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45b96c3
Add PR check to validate compatibility with Node 12
henrymercer Mar 28, 2022
9e40359
Improve code comments
henrymercer Mar 28, 2022
2f4dd4b
Use `git add --all .`
henrymercer Mar 29, 2022
73ba7ff
Merge branch 'main' into henrymercer/pr-check-validate-node-12-build
henrymercer Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,34 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 45

strategy:
fail-fast: true
matrix:
node-types-version: [12.12, current]

steps:
- uses: actions/checkout@v2

- name: Update version of @types/node
if: matrix.node-types-version != 'current'
env:
NODE_TYPES_VERSION: ${{ matrix.node-types-version }}
run: |
# Export `NODE_TYPES_VERSION` so it's available to jq
export NODE_TYPES_VERSION="${NODE_TYPES_VERSION}"
henrymercer marked this conversation as resolved.
Show resolved Hide resolved
contents=$(jq '.devDependencies."@types/node" = env.NODE_TYPES_VERSION' package.json)
henrymercer marked this conversation as resolved.
Show resolved Hide resolved
echo "${contents}" > package.json
# Usually we run `npm install` on macOS to ensure that we pick up macOS-only dependencies.
# However we're not checking in the updated lockfile here, so it's fine to run
# `npm install` on Linux.
npm install

git config --global user.email "[email protected]"
git config --global user.name "github-actions[bot]"
# The period in `git add --all .` ensures that we stage deleted files too.
git add --all .
git commit -m "Use @types/node=${NODE_TYPES_VERSION}"

- name: Check generated JS
run: .github/workflows/script/check-js.sh

Expand Down