Add PR check to validate compatibility with Node 12 #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple PR check that sets the
@types/nodedependency to version 12.12 (i.e. types for Node 12), then attempts to compile the Action. This helps us guard against introducing new code that doesn't run with Node 12.Example successful job: https://github.com/github/codeql-action/runs/5722503871?check_suite_focus=true
Example failed job after introducing some Node 16 only code: https://github.com/github/codeql-action/runs/5722718273?check_suite_focus=true
Note that we'll need to update the set of required checks after merging this PR.
Merge / deployment checklist