Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heuristic rule for Puppet and Pascal .pp files #4289

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Heuristic rule for Puppet and Pascal .pp files #4289

merged 1 commit into from
Oct 29, 2018

Conversation

pchaigno
Copy link
Contributor

@pchaigno pchaigno commented Oct 5, 2018 •
edited
Loading

This pull request adds a heuristic rule for Puppet and Pascal .pp files. Fixes #3605.

/cc @caged

Checklist:

  • I am fixing a misclassified language
    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.

@pchaigno pchaigno mentioned this pull request Oct 8, 2018
Closed
Alhadis
Alhadis reviewed Oct 8, 2018
View reviewed changes
lib/linguist/heuristics.yml Outdated Show resolved Hide resolved
@pchaigno
Copy link
Contributor Author

I've updated the pull request with the new heuristic rule for Puppet.

@pchaigno pchaigno requested a review from lildude October 27, 2018 16:50
lildude
lildude approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pchaigno pchaigno merged commit e443120 into github-linguist:master Oct 29, 2018
@pchaigno pchaigno deleted the pp-heuristic branch October 29, 2018 11:43
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Alhadis Alhadis Alhadis approved these changes

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Puppet is often misclassified as many different languages
3 participants
@pchaigno @lildude @Alhadis