Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppet is often misclassified as many different languages #3605

Closed
caged opened this issue May 5, 2017 · 3 comments · Fixed by #4289
Closed

Puppet is often misclassified as many different languages #3605

caged opened this issue May 5, 2017 · 3 comments · Fixed by #4289
Labels
Misidentified Language

Comments

@caged
Copy link
Contributor

caged commented May 5, 2017

We've noticed internally that Puppet is often misclassified as Pascal. After a little further digging, it looks like Puppet is misidentified as a host of different languages from Pascal to Ruby.

Prior art:
#2333
#2031
#1267
@caged
Copy link
Contributor Author

caged commented May 5, 2017

Quick update...It appears most of the Ruby classifications are correct if we're looking at the vim modeline. Even though they are puppet, the author or authoring application tagged them as ruby. The Haskell classifications also appears to be correct.

@caged caged mentioned this issue May 5, 2017
Closed
@smola
Copy link
Contributor

smola commented Jul 17, 2017

It seems the main problem are these Puppet files that have only include foo lines. Adding a simple sample seems to solve the problem at the classifier (as in #3606).

smola added a commit to smola/linguist that referenced this issue Jul 31, 2017
@smola
add new Puppet sample: short init.pp
6b8b49f 
A lot of Puppet .pp files are misclassified as Pascal.
This usually happens with short files that are just
includes (see github-linguist#3605).

Added a synthetic init.pp that, for practical purposes,
is the same as a lot of the misidentified files.
@pchaigno pchaigno mentioned this issue Oct 5, 2018
Merged
3 tasks
@pchaigno
Copy link
Contributor

pchaigno commented Oct 8, 2018

The new pull request at #4289 should fix this. @caged I'd love a review if you've got the bandwidth!

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Misidentified Language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Heuristic rule for Puppet and Pascal .pp files pchaigno/linguist
3 participants
@caged @smola @pchaigno