[engine] git log 파싱에 사용되는 separator 개선 #770
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import { getCommitMessageType } from "./commit.util"; | ||
| import getCommitRaws from "./parser"; | ||
| import type { CommitRaw, DifferenceStatistic } from "./types"; | ||
|
|
||
|
|
@@ -36,11 +35,15 @@ describe("commit message type", () => { | |
| }); | ||
|
|
||
| describe("getCommitRaws", () => { | ||
| const FRONT_NEW_LINE = "\n\n"; | ||
| const INDENTATION = " "; | ||
|
|
||
| const fakeAuthor = "John Park\[email protected]\nSun Sep 4 20:17:59 2022 +0900"; | ||
| const fakeCommitter = `John Park 2\[email protected]\nSun Sep 5 20:17:59 2022 +0900`; | ||
| const fakeCommitMessage = `commit message\n${INDENTATION}`; | ||
| const fakeCommitMessageAndBody = `commit message title\n${INDENTATION}\n${INDENTATION}commit message body`; | ||
| const fakeCommitHash = "a\nb"; | ||
| const fakeCommitRef = "HEAD"; | ||
| const fakeCommitFileChange = "10\t0\ta.ts\n1\t0\tREADME.md"; | ||
|
|
||
| const commonExpectatedResult: CommitRaw = { | ||
|
|
@@ -73,23 +76,23 @@ describe("getCommitRaws", () => { | |
|
|
||
| it.each([ | ||
| [ | ||
| `${FRONT_NEW_LINE}${"a\n"}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| id: "a", | ||
| parents: [], | ||
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${"c\nd"}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| id: "c", | ||
| parents: ["d"], | ||
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${"d\ne f"}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| id: "d", | ||
|
|
@@ -103,47 +106,47 @@ describe("getCommitRaws", () => { | |
|
|
||
| it.each([ | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${"HEAD"}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| branches: ["HEAD"], | ||
| tags: [], | ||
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${"HEAD -> main, origin/main, origin/HEAD"}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| branches: ["HEAD", "main", "origin/main", "origin/HEAD"], | ||
| tags: [], | ||
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${"HEAD, tag: v1.0.0"}\n${fakeAuthor}\n${fakeCommitter}$\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| branches: ["HEAD"], | ||
| tags: ["v1.0.0"], | ||
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${"HEAD -> main, origin/main, origin/HEAD, tag: v2.0.0"}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| branches: ["HEAD", "main", "origin/main", "origin/HEAD"], | ||
| tags: ["v2.0.0"], | ||
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${"HEAD, tag: v2.0.0, tag: v1.4"}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| branches: ["HEAD"], | ||
| tags: ["v2.0.0", "v1.4"], | ||
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${""}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| branches: [], | ||
|
|
@@ -157,7 +160,7 @@ describe("getCommitRaws", () => { | |
|
|
||
| it.each([ | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}\n${"10\t0\ta.ts\n1\t0\tREADME.md"}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| differenceStatistic: { | ||
|
|
@@ -171,7 +174,7 @@ describe("getCommitRaws", () => { | |
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}\n${"3\t3\ta.ts"}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| differenceStatistic: { | ||
|
|
@@ -182,7 +185,7 @@ describe("getCommitRaws", () => { | |
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}\n${"4\t0\ta.ts"}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| differenceStatistic: { | ||
|
|
@@ -193,7 +196,7 @@ describe("getCommitRaws", () => { | |
| }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}\n${"0\t6\ta.ts\n2\t0\tb.ts\n3\t3\tc.ts"}`, | ||
| { | ||
| ...commonExpectatedResult, | ||
| differenceStatistic: { | ||
|
|
@@ -213,7 +216,7 @@ describe("getCommitRaws", () => { | |
| }); | ||
|
|
||
| it(`should parse gitlog to commitRaw(multiple commits)`, () => { | ||
| const mockLog = `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}\n${fakeCommitFileChange}\n\n\n\n${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessage}`; | ||
| const result = getCommitRaws(mockLog); | ||
| const expectedResult = [ | ||
| { ...commonExpectatedResult, differenceStatistic: expectedFileChange }, | ||
|
|
@@ -225,23 +228,23 @@ describe("getCommitRaws", () => { | |
|
|
||
| it.each([ | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${"commit message title"}\n${INDENTATION}`, | ||
| { ...commonExpectatedResult, message: "commit message title" }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${"commit message title"}\n${INDENTATION}${"commit message body"}`, | ||
| { ...commonExpectatedResult, message: "commit message title\ncommit message body" }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${"commit message title"}\n${INDENTATION}\n${INDENTATION}${"commit message body"}`, | ||
| { ...commonExpectatedResult, message: "commit message title\n\ncommit message body" }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${"commit message title"}\n${INDENTATION}\n${INDENTATION}\n${INDENTATION}${"commit message body"}`, | ||
| { ...commonExpectatedResult, message: "commit message title\n\n\ncommit message body" }, | ||
| ], | ||
| [ | ||
| `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n\n${INDENTATION}`, | ||
| { ...commonExpectatedResult, message: "" }, | ||
| ], | ||
| ])("should parse gitlog to commitRaw(commit message)", (mockLog, expectedResult) => { | ||
|
|
@@ -250,7 +253,7 @@ describe("getCommitRaws", () => { | |
| }); | ||
|
|
||
| it(`should parse gitlog to commitRaw(commit message body and file change)`, () => { | ||
| const mockLog = `${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}\n${fakeCommitMessageAndBody}\n${fakeCommitFileChange}`; | ||
| const result = getCommitRaws(mockLog); | ||
| const expectedResult = { | ||
| ...commonExpectatedResult, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
드디어 사라졌군요!!! 🎆🎆🎆