-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[engine] git log 파싱에 사용되는 separator 개선 #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGGGGTM 입니다!!!
``${FRONT_NEW_LINE}${fakeCommitHash}\n${fakeCommitRef}\n${fakeAuthor}\n${fakeCommitter}`
굳이 따지자면 요런 부분들이 가독성을 조금 해쳐서, 조금 변수화 시키는것도 괜찮을 것 같습니다.
아니면 아예 string value로 그대로 표현해도 좋을 것 같아요.
@@ -1,5 +1,4 @@ | |||
import { getCommitMessageType } from "./commit.util"; | |||
import { COMMIT_SEPARATOR, GIT_LOG_SEPARATOR } from "./constant"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
드디어 사라졌군요!!! 🎆🎆🎆
Related issue
Result
AS-IS
COMMIT_SEPARATOR
와GIT_LOG_SEPARATOR
를 난수 문자열로 사용git log format
format example
TO-BE
\n
4개 (--numstat
옵션에서 기본적으로 적용되는\n
2개 + 직접 지정한\n
2개)\n
git log format
format example
test result
Work list
\n
4개 (--numstat
옵션에서 기본적으로 적용되는\n
2개 + 직접 지정한\n
2개)\n
Discussion