-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uniswap price integration #6231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6231 +/- ##
==========================================
+ Coverage 27.08% 27.10% +0.02%
==========================================
Files 290 290
Lines 26628 26626 -2
Branches 3942 3941 -1
==========================================
+ Hits 7212 7218 +6
+ Misses 19145 19141 -4
+ Partials 271 267 -4
Continue to review full report at Codecov.
|
27c4e73
to
c1d2842
Compare
@santteegt just tried this and it works (mostly) like a charm! a few testing notes:
|
c1d2842
to
de1865c
Compare
@santteegt I see theres a conflict here - is this PR now out of date given the recent changes? |
de1865c
to
abc6d83
Compare
Hi @danlipert, Looks like @owocki has cherrypicked my commit, made a small change to fetch prices only for the Panvala token, and pushed this (commit) to master I've rebased my PR excluding this change. In case it is required let me know to put it back again |
4268378
to
ad18d47
Compare
@owocki thoughts on this? I dont know if we want to limit the scope to Panvala or if we are good to source all the coins since this PR undoes the changes you did |
last time we did all coins from uniswap it messed up price feeds across the site (some stable coins have low liquidity and were valued at 10x what they should have been). would prefer to keep the scope limited to just PAN for now. but maybe make it easy to add new uniswap tokens at a future date if people keep adding those coins. |
ad18d47
to
73f7d02
Compare
Changes to my PR has now been restored. Now, my PR is basically doing nothing but worth mentioning that the initial implementation was already merged into master before approving this PR 😄 |
@santteegt lol I'll be closing this one out cause like you said , your commit is already in :) |
Description
get_prices
now fetch allETH=>token
andtoken=>USD
prices from the Uniswap exchange by querying the Uniswap subgraph on mainnetRefers/Fixes
Refs: #6192