Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as a user, i want uniswap price integration so that all the greatest HOTT ETH coins are priced on gitcoin #6192

Closed
owocki opened this issue Mar 10, 2020 · 12 comments

Comments

@owocki
Copy link
Contributor

owocki commented Mar 10, 2020

User Story

as a user, i want uniswap price integration so that all the greatest HOTT ETH coins are priced on gitcoin

Why Is this Needed

Summary:

Description

Type:
feature

Current Behavior

uniswap not a price oracle

Expected Behavior

the get_prices management command is modified such that each coin on uniswap will now have its ETH pair synced to the gitcoin DB.

Definition of Done

see above

I can use PAN on gitcoin

Data Requirements

comment: # (How will we measure the success of this feature? What kind of tracking is needed for this feature (clicks, impressions, flag)?)

Additional Information

Must be completed (completed == ready to push to prod) by this Sunday

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.0 ETH (202.39 USD @ $202.39/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Mar 10, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 weeks, 5 days ago.
Please review their action plans below:

1) santteegt has been approved to start work.

Some code/ideas that could be used to complete this bounty

MakerDAo Uniswap Price Feed repo

Exchange API

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link
Member

@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@owocki
Copy link
Contributor Author

owocki commented Mar 13, 2020

@santteegt how goes? are we on track for thsi?

Must be completed (completed == ready to push to prod) by this Sunday

@santteegt
Copy link
Contributor

HI @owocki,

Currently working on this. Will be sending a PR tomorrow for a review

@santteegt
Copy link
Contributor

santteegt commented Mar 15, 2020

Hi @owocki,

Quick question before sending my PR. Do you also require token->USD price data or ETH->token pairs only?

@owocki
Copy link
Contributor Author

owocki commented Mar 16, 2020 via email

@santteegt
Copy link
Contributor

Not at all. So I'll update my PR to include both trading pairs

@gitcoinbot
Copy link
Member

@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.0 ETH (117.09 USD @ $117.09/ETH) has been submitted by:

  1. @santteegt

@owocki please take a look at the submitted work:


@santteegt
Copy link
Contributor

I tried sending a payment reminder through the UI but I got an error. Perhaps due to the bounty has already expired 😄

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 1.0 ETH (204.13 USD @ $204.13/ETH) attached to this issue has been approved & issued to @santteegt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants