-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as a user, i want uniswap price integration so that all the greatest HOTT ETH coins are priced on gitcoin #6192
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 1.0 ETH (202.39 USD @ $202.39/ETH) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 2 weeks, 5 days ago. 1) santteegt has been approved to start work. Some code/ideas that could be used to complete this bounty MakerDAo Uniswap Price Feed repo Learn more on the Gitcoin Issue Details page. |
@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@santteegt how goes? are we on track for thsi?
|
HI @owocki, Currently working on this. Will be sending a PR tomorrow for a review |
Hi @owocki, Quick question before sending my PR. Do you also require |
both would be best. does that increase complexity a lot?
…On Sun, Mar 15, 2020 at 9:27 AM Santiago Gonzalez Toral < ***@***.***> wrote:
Hi @owocki <https://github.com/owocki>,
Quick question before sending my PR. Do you require token->USD price data
only, or ETH->token prices also?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6192 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD5PCNODZHWFWEUPAIFVPDRHTXWPANCNFSM4LEVIBYQ>
.
_________________________________________
gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results <https://gitcoin.co/results>
|
Not at all. So I'll update my PR to include both trading pairs |
@santteegt Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 1.0 ETH (117.09 USD @ $117.09/ETH) has been submitted by: @owocki please take a look at the submitted work:
|
I tried sending a payment reminder through the UI but I got an error. Perhaps due to the bounty has already expired 😄 |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 1.0 ETH (204.13 USD @ $204.13/ETH) attached to this issue has been approved & issued to @santteegt.
|
User Story
as a user, i want uniswap price integration so that all the greatest HOTT ETH coins are priced on gitcoin
Why Is this Needed
Summary:
Description
Type:
feature
Current Behavior
uniswap not a price oracle
Expected Behavior
the get_prices management command is modified such that each coin on uniswap will now have its ETH pair synced to the gitcoin DB.
Definition of Done
see above
I can use PAN on gitcoin
Data Requirements
comment: # (How will we measure the success of this feature? What kind of tracking is needed for this feature (clicks, impressions, flag)?)
Additional Information
Must be completed (completed == ready to push to prod) by this Sunday
The text was updated successfully, but these errors were encountered: